Fix T70667: crash playing animation (after deleting rigid body obj)
ClosedPublic
Actions

Authored by Philipp Oeser (lichtwerk) on Oct 10 2019, 1:44 PM.

Details

Reviewers

Bastien Montagne (mont29)
Sybren A. Stüvel (sybren)

Maniphest Tasks

T70667: Playing animation (after deleting rigid body obj) crashes blender. (Different from the T70588 !)

Commits

rBd54ccb90ab57: Fix T70667: crash playing animation (after deleting rigid body obj)

Summary

Was crashing due to RBW mssing shared->physics_world.
This can be gained back by BKE_rigidbody_validate_sim_world.

Other possibility would be to check for shared->physics_world early in
BKE_scene_check_rigidbody_active?

Diff Detail

Repository

rB Blender

Branch

T70667 (branched from master)

Build Status

Buildable 5309
Build 5309: arc lint + arc unit

Event Timeline

Philipp Oeser (lichtwerk) created this revision.Oct 10 2019, 1:44 PM

Harbormaster completed remote builds in B5309: Diff 18921.Oct 10 2019, 1:44 PM

I guess that’s a valid change… Would be worth adding a comment (with report reference) about why/how that case (no rebuild required, yet NULL physics_world) can happen? This seems to be related to undo/redo, from quick skim over the report?

This revision is now accepted and ready to land.Oct 11 2019, 4:29 PM

Closed by commit rBd54ccb90ab57: Fix T70667: crash playing animation (after deleting rigid body obj) (authored by Philipp Oeser (lichtwerk)). · Explain WhyOct 15 2019, 11:10 AM

This revision was automatically updated to reflect the committed changes.

Philipp Oeser (lichtwerk) added a commit: rBd54ccb90ab57: Fix T70667: crash playing animation (after deleting rigid body obj).

Revision Contents
Changeset List

Path

Size

source/

blender/

blenkernel/

intern/

rigidbody.c

5 lines

Diff 18921

View Options

source/blender/blenkernel/intern/rigidbody.c

Fix T70667: crash playing animation (after deleting rigid body obj)ClosedPublicActions