That would lead to crashes and other issues. The solution is not elegant
though, it involves resyncing all the collections again.
Details
Details
- Reviewers
Brecht Van Lommel (brecht) - Maniphest Tasks
- T69644: Objects in hidden collection become visible when the hidden collection gets parented to a visible collection
T68586: Crash when hiding collection that contains a disabled collection - Commits
- rBaf5cc8cbd411: Fix T69644 / T68586: objects flag unsynced when drag hidden collections
Diff Detail
Diff Detail
- Repository
- rB Blender
Event Timeline
Comment Actions
@Brecht Van Lommel (brecht) this solution scream "wrong" to me all over it. It bothers me to have to run sync twice, but if I were to create a _shallow sync function or any similar hack I'm afraid we would be adding too much extra hassle in the code, that could easily get out of sync from the main functions. Any 2 cents?
Comment Actions
@Sebastian Parborg (zeddb) could you try (before and after) this in a production computer with production scenes, to see if it got too bad in real life?
Comment Actions
@Dalai Felinto (dfelinto) how thorough do you want this testing to be? Just a simple subjective test or what?
Comment Actions
@Sebastian Parborg (zeddb) if it pass a subjective test, then it is good. If it doesn't than numbers would help base our decision here.
Comment Actions
We tested moving and toggling hiding/disabling on a production scene and we could not subjectively notice any difference.