Details

Reviewers

Jeroen Bakker (jbakker)
Campbell Barton (campbellbarton)

Commits

rBcd827194f7cc: Paint: Option to disable antialiasing

Summary

You may want to disable antialiasing if you are working with pixel art
or low resolution textures. It is enabled by default.
There is still a flag available in ebrushFlags, but it is used in another
patch. I added ebrushFlags2, but I need to reorganize all flags at some
point in a way that makes sense.

Diff Detail

Repository

rB Blender

Branch

paint-disable-antialiasing (branched from master)

Build Status

Buildable 5496
Build 5496: arc lint + arc unit

Event Timeline

Pablo Dobarro (pablodp606) created this revision.Oct 10 2019, 9:55 PM

Harbormaster completed remote builds in B5323: Diff 18943.Oct 10 2019, 9:55 PM

Metin Seven (MetinSeven) awarded a token.Oct 11 2019, 8:32 AM

Kenn Nyström (Frozen_Death_Knight) awarded a token.Oct 11 2019, 1:07 PM

Brecht Van Lommel (brecht) added reviewers: Jeroen Bakker (jbakker), Campbell Barton (campbellbarton).Oct 11 2019, 4:17 PM

gobb_blend awarded a token.Oct 11 2019, 5:16 PM

Jeroen Bakker (jbakker) requested changes to this revision.Oct 14 2019, 11:03 AM

Jeroen Bakker (jbakker) added inline comments.

source/blender/makesrna/intern/rna_brush.c
2014	Set default for this RNA property to true.

This revision now requires changes to proceed.Oct 14 2019, 11:03 AM

There is no need for a flag2, there is a free bit in flag already.

Even so, it's getting near full, if we do add new flags would prefer to add flags which for spesific purposes (perhaps modes).

source/blender/makesrna/intern/rna_brush.c
2014	We don't need to set the defaults in RNA if they're set in `DNA_brush_defaults.h`.

Campbell Barton (campbellbarton) added inline comments.Oct 14 2019, 11:32 AM

source/blender/makesrna/intern/rna_brush.c
2010	For UV's we have `pixel_snap_mode`. Think this could be called "use_snap_to_pixel" ? Since this only relates to brush placement.

Pablo Dobarro (pablodp606) added inline comments.Oct 14 2019, 10:09 PM

source/blender/makesrna/intern/rna_brush.c
2010	It does not disable float precision placement, it disables subpixel sampling. That way you will only get a 1 or a 0 curve mask value in a pixel when painting with a sharp falloff.

Pablo Dobarro (pablodp606) added a project: BF Blender (2.81).Oct 15 2019, 3:23 PM

Instead of flag2, we could add a sampling_flag.
Booleans should use use_ prefix.

Review update, rebase

Harbormaster completed remote builds in B5434: Diff 19149.Oct 21 2019, 1:42 PM

Jeroen Bakker (jbakker) requested changes to this revision.Oct 30 2019, 8:19 AM

Jeroen Bakker (jbakker) added inline comments.

source/blender/makesdna/DNA_brush_types.h
439	`eBrushSamplingFlags` is a better description for this type. Also add a comment where this flag is stored in the DNA for reference.

This revision now requires changes to proceed.Oct 30 2019, 8:19 AM

Paul (rice) mentioned this in T71216: Brush Falloff in Texture Paint is broken now.Oct 30 2019, 2:41 PM

Review update

Harbormaster completed remote builds in B5490: Diff 19271.Oct 30 2019, 2:56 PM

Jeroen Bakker (jbakker) accepted this revision.Oct 30 2019, 3:43 PM

This revision is now accepted and ready to land.Oct 30 2019, 3:43 PM

One minor issue, otherwise LGTM.

release/scripts/startup/bl_ui/properties_paint_common.py
207	Shouldn't this only display if `projpaint` is false?

Pablo Dobarro (pablodp606) added inline comments.Oct 30 2019, 4:23 PM

release/scripts/startup/bl_ui/properties_paint_common.py
207	If I check for `projpaint` the option does not appear in the 2D view when painting with a 3D and a 2D view at the same time. I think most users would prefer to have this option always available even if it only affects 2D painting.

Campbell Barton (campbellbarton) added inline comments.Oct 30 2019, 4:34 PM

release/scripts/startup/bl_ui/properties_paint_common.py
207	when painting with a 3D and a 2D view at the same time. Not sure why you would use a 2D image editor to configure the brush for the 3D view. There are already checks for `projpaint``to avoid showing settings which are not used.