Page MenuHome
Differential D6053

Fix T69921: VSE - Waveforms unnecessary redrawn on offset change
ClosedPublic
Actions

Authored by Richard Antalik (ISS) on Oct 13 2019, 4:19 AM.

Details

Reviewers
Sergey Sharybin (sergey)
Sybren A. Stüvel (sybren)
Maniphest Tasks
T69921: VSE: Waveforms unnecessary redrawn on offset change
Commits
rBa60a623a1ac5: Fix T69921: VSE - Waveforms unnecessary redrawn on offset change
Summary

Waveform is freed in sound_load_audio() when sound length is queried by BKE_sound_info_get().

Add argument free_waveform, so BKE_sound_info_get() can skip waveform freeing, as it is not expected to alter sound.

Diff Detail

Repository
rB Blender

Event Timeline

Richard Antalik (ISS) created this revision.Oct 13 2019, 4:19 AM
Harbormaster completed remote builds in B5343: Diff 18982.Oct 13 2019, 4:19 AM
Sergey Sharybin (sergey) added a comment.Oct 13 2019, 11:04 AM

Probably is fine, but totally deserved more explanation about what exactly is causing the issue.

Richard Antalik (ISS) edited the summary of this revision. (Show Details)Oct 16 2019, 2:56 AM
Richard Antalik (ISS) added a comment.Oct 16 2019, 2:59 AM
In D6053#139278, @Sergey Sharybin (sergey) wrote:

Probably is fine, but totally deserved more explanation about what exactly is causing the issue.

added description

Sybren A. Stüvel (sybren) accepted this revision.Jan 16 2020, 5:13 PM
Sybren A. Stüvel (sybren) added a reviewer: Sybren A. Stüvel (sybren).
Sybren A. Stüvel (sybren) added a subscriber: Sybren A. Stüvel (sybren).

Apart from the inline-mentioned comment, LGTM.

source/blender/blenkernel/intern/sound.c
1101–1103

This could use a comment to explain why this doesn't cause a memory leak. And maybe also document the reason why memory shouldn't be freed here, as it's not instantly obvious.

Richard Antalik (ISS) updated this revision to Diff 21057.Jan 22 2020, 1:21 PM
Richard Antalik (ISS) marked an inline comment as done.
  • Add comment
Harbormaster completed remote builds in B6357: Diff 21057.Jan 22 2020, 1:21 PM
This revision was not accepted when it landed; it landed in state Needs Review.Jan 22 2020, 1:38 PM
Closed by commit rBa60a623a1ac5: Fix T69921: VSE - Waveforms unnecessary redrawn on offset change (authored by Richard Antalik (ISS)). · Explain Why
This revision was automatically updated to reflect the committed changes.
Richard Antalik (ISS) added a commit: rBa60a623a1ac5: Fix T69921: VSE - Waveforms unnecessary redrawn on offset change.

Revision Contents
Changeset List

PathSize
source/
blender/
blenkernel/
intern/
14 lines

Diff 21058

View Options

source/blender/blenkernel/intern/sound.c

Loading...