Cleanup: depsgraph access in particle_edit.c
ClosedPublic
Actions

Authored by Philipp Oeser (lichtwerk) on Oct 15 2019, 12:23 PM.

Details

Reviewers

Dalai Felinto (dfelinto)
Sergey Sharybin (sergey)
Brecht Van Lommel (brecht)

Commits

rB9054b834028f: Cleanup depsgraph access in particle_edit.c

Summary

'PE_set_data' / 'PE_set_view3d_data' would give us a depsgraph already,
so use it.

Also fix access to PEData->depsgraph without calling 'PE_set_data' prior.

Addresses concern raised in rBcf2c09002fae.

Diff Detail

Repository: rB Blender

Event Timeline

Philipp Oeser (lichtwerk) created this revision.Oct 15 2019, 12:23 PM

Harbormaster completed remote builds in B5368: Diff 19021.Oct 15 2019, 12:23 PM

On an additional level, we can probably do PEData data = {0}; and have asserts to catch cases where we miss initialization?

This revision is now accepted and ready to land.Oct 15 2019, 12:35 PM

In D6067#139644, @Sergey Sharybin (sergey) wrote:

On an additional level, we can probably do PEData data = {0}; and have asserts to catch cases where we miss initialization?

There is some more possible cleanup to be done here (I think):

use PEData's object, scene (sometimes depsgraph) in more places [PE_mouse_particles, PE_box_select, PE_circle_select, PE_lasso_select, possibly shape_cut_exec] instead of getting them separately...
but will do this in a separate step/commit, OK?

And just to make sure: this Diff [without the additional steps] can/should go into 2.81-release, right?

Closed by commit rB9054b834028f: Cleanup depsgraph access in particle_edit.c (authored by Philipp Oeser (lichtwerk)). · Explain WhyOct 17 2019, 1:19 PM

This revision was automatically updated to reflect the committed changes.

Philipp Oeser (lichtwerk) added a commit: rB9054b834028f: Cleanup depsgraph access in particle_edit.c.