Page MenuHome
Differential D6072

Fix T62882: Make Dynamic Paint update weights in viewport
ClosedPublic
Actions

Authored by Nico Zevallos (gnastacast) on Oct 15 2019, 6:44 PM.

Details

Reviewers
Campbell Barton (campbellbarton)
Bastien Montagne (mont29)
Sergey Sharybin (sergey)
Jeroen Bakker (jbakker)
Commits
rB1982d110f4ec: Fix T62882: Make Dynamic Paint update weights in viewport
Summary

Related to T62882
When the SupportsMapping modifier flag was added 3fab39f to the dynamic paint modifier it was added commented out. It may have not worked back then, but it seems to work fine now.
MOD_weightvgedit.c was updated similarly in 2c5a919

Interestingly all of the weight editing modifiers (MOD_weightvgmix.c MOD_weightvgproximity.c MOD_weightvg_util.c) also have the eModifierTypeFlag_SupportsEditmode tag as well, even though toggling the option in the UI doesn't do anything in edit mode (The modifier always affects edit mode.) I am wondering if I should add the same tag to MOD_dynamicpaint.c so that it behaves in the same way.

Diff Detail

Repository
rB Blender

Event Timeline

Nico Zevallos (gnastacast) created this revision.Oct 15 2019, 6:44 PM
Nico Zevallos (gnastacast) retitled this revision from Make Dynamic Paint update weights in viewport to Fix T62882: Make Dynamic Paint update weights in viewport.Oct 16 2019, 4:02 PM
Nico Zevallos (gnastacast) added a project: Modifiers.Oct 17 2019, 3:12 AM
Brecht Van Lommel (brecht) added reviewers: Campbell Barton (campbellbarton), Bastien Montagne (mont29), Sergey Sharybin (sergey).Oct 25 2019, 5:22 AM
Brecht Van Lommel (brecht) added a project: BF Blender (2.81).
Sergey Sharybin (sergey) added a comment.Oct 29 2019, 11:26 AM

Not really my area. If it works just commit i guess? :)

Nico Zevallos (gnastacast) mentioned this in T67690: Weight paint not showing in Dynamic Paint.Nov 6 2019, 12:29 AM
Philipp Oeser (lichtwerk) added a reviewer: Jeroen Bakker (jbakker).Nov 7 2019, 2:16 PM
Philipp Oeser (lichtwerk) added subscribers: Jeroen Bakker (jbakker), Philipp Oeser (lichtwerk).

adding @Jeroen Bakker (jbakker) (since he did T63819: Overlay: DynamicPaint overlay)

Fin O'Riordan (fin.eskimo) added a subscriber: Fin O'Riordan (fin.eskimo).Nov 26 2019, 8:05 AM
Fin O'Riordan (fin.eskimo) added a comment.Nov 27 2019, 12:33 PM

Can confirm that this works, although it would be more useful if weights could be overlayed outside of weight paint mode

Jeroen Bakker (jbakker) accepted this revision.Nov 27 2019, 1:24 PM
This revision is now accepted and ready to land.Nov 27 2019, 1:24 PM
Closed by commit rB1982d110f4ec: Fix T62882: Make Dynamic Paint update weights in viewport (authored by Nico Zevallos (gnastacast), committed by Jeroen Bakker (jbakker)). · Explain WhyJan 21 2020, 11:01 AM
This revision was automatically updated to reflect the committed changes.
Jeroen Bakker (jbakker) added a commit: rB1982d110f4ec: Fix T62882: Make Dynamic Paint update weights in viewport.

Revision Contents
Changeset List

PathSize
source/
blender/
modifiers/
intern/
2 lines

Diff 19032

View Options

source/blender/modifiers/intern/MOD_dynamicpaint.c

Loading...