Fix (unreported) VSE scene strip should not be able to set the scene to self
ClosedPublic
Actions

Authored by Philipp Oeser (lichtwerk) on Oct 15 2019, 10:12 PM.

Details

Reviewers

Sergey Sharybin (sergey)
Richard Antalik (ISS)
Campbell Barton (campbellbarton)

Commits

rB0dcc5572d6ab: Fix (unreported) VSE scene strip should not be able to set the scene to self

Summary

Spotted while looking into T70845

Diff Detail

Repository

rB Blender

Branch

VSE_scene_strip_selfcheck (branched from master)

Build Status

Buildable 5377
Build 5377: arc lint + arc unit

Event Timeline

Philipp Oeser (lichtwerk) created this revision.Oct 15 2019, 10:12 PM

Harbormaster completed remote builds in B5377: Diff 19038.Oct 15 2019, 10:12 PM

For everyone making decisions on this,
If we can't set the scene to it's self then the whole compositor pipeline will collapse immediately.
As this is the only method (for now) to playback compositor and playback and AUTO RENDER 3D scene within compositor.

If it needs to be fixed, then we will need:

A method for auto rendering Render layers per frame in compositor
Playback at a given frame rate by viewer, Which can be done by importing image sequence in the viewer though.

For some clarity here is our hack:
https://www.youtube.com/watch?v=0OdFo8evnYs

I didn't know about PROP_ID_SELF_CHECK. I guess I should close D6054: Fix T69636: Crash when rendering scene srtip.?

Campbell Barton (campbellbarton) accepted this revision.Oct 16 2019, 2:13 AM

This revision is now accepted and ready to land.Oct 16 2019, 2:13 AM

@Fahad Hasan (cgvirus) this was an intentional change made quite some time ago. T52586: Disable scenes using themselves as sequence strips 2.8 Proposal

Alright, I have already mapped out a hack for caching in image editor. But the only lacking currently we are having is the auto render while scrubbing through Render Layer in compositor. Is there any way to do that? Thanks. @Campbell Barton (campbellbarton)

Edit: ^ Bad idea. Creates another level of mess. Current config is better and have successfully implemented it.

Richard Antalik (ISS) mentioned this in D6054: Fix T69636: Crash when rendering scene srtip..Oct 16 2019, 4:19 AM

Sergey Sharybin (sergey) accepted this revision.Oct 16 2019, 9:02 AM

Richard Antalik (ISS) accepted this revision.Oct 16 2019, 9:13 AM

Closed by commit rB0dcc5572d6ab: Fix (unreported) VSE scene strip should not be able to set the scene to self (authored by Philipp Oeser (lichtwerk)). · Explain WhyOct 16 2019, 9:43 AM

This revision was automatically updated to reflect the committed changes.

Philipp Oeser (lichtwerk) added a commit: rB0dcc5572d6ab: Fix (unreported) VSE scene strip should not be able to set the scene to self.

Philipp Oeser (lichtwerk) mentioned this in T70845: Blender VSE with a Scene Strip Crash.Oct 17 2019, 10:24 AM