Page MenuHome
Differential D6076

Volumetric: Debug Voxel Size
ClosedPublic
Actions

Authored by Jeroen Bakker (jbakker) on Oct 16 2019, 11:02 AM.

Details

Reviewers
Sebastián Barschkis (sebbas)
Clément Foucault (fclem)
Maniphest Tasks
T70678: smoke sim glitch in solidmode
Commits
rB78f8270ad3f3: Volumetric: Debug Voxel Size and Location
rB9d228c688d71: Volumetric: Debug Voxel Size and Location
Summary

When displaying the voxel size for an adaptive domain the resolution of the adaptive domain was used to calculate the world size of the voxel.
This patch changes this to use the initial size of the domain.

Diff Detail

Repository
rB Blender

Event Timeline

Jeroen Bakker (jbakker) created this revision.Oct 16 2019, 11:02 AM
Harbormaster completed remote builds in B5385: Diff 19052.Oct 16 2019, 11:02 AM
Jeroen Bakker (jbakker) added reviewers: Sebastián Barschkis (sebbas), Clément Foucault (fclem).Oct 16 2019, 11:03 AM
Jeroen Bakker (jbakker) added projects: GPU / Viewport, Physics, BF Blender (2.81).
Jeroen Bakker (jbakker) added a task: T70678: smoke sim glitch in solidmode.
Sebastián Barschkis (sebbas) added a comment.Oct 16 2019, 12:17 PM

cube.patch1 KBDownload

Same as before. I just added a translation to the voxel indicator so that it stays inside the domain when resizes occur.

Jeroen Bakker (jbakker) planned changes to this revision.Oct 17 2019, 10:03 AM

Yes, just noticed that the matrix needed more changes to work correct.

Jeroen Bakker (jbakker) updated this revision to Diff 19084.Oct 17 2019, 10:09 AM

Added the changes @Sebastián Barschkis (sebbas) proposed.

Harbormaster completed remote builds in B5398: Diff 19084.Oct 17 2019, 10:09 AM
Sebastián Barschkis (sebbas) accepted this revision.Oct 17 2019, 10:24 AM

Perfect!

This revision is now accepted and ready to land.Oct 17 2019, 10:24 AM
Jeroen Bakker (jbakker) mentioned this in T70868: Unexpected Behavior - Smoke domain does not match viewport container.Oct 17 2019, 10:30 AM
Clément Foucault (fclem) accepted this revision.Oct 17 2019, 11:46 AM
Jeroen Bakker (jbakker) updated this revision to Diff 19087.Oct 17 2019, 11:52 AM

Velocity debugging

Harbormaster completed remote builds in B5401: Diff 19087.Oct 17 2019, 11:52 AM
Jeroen Bakker (jbakker) requested review of this revision.Oct 17 2019, 11:54 AM

@Clément Foucault (fclem): mind having a second look at this patch :-) I just fixed a related issue T70868 :-)

Clément Foucault (fclem) accepted this revision.Oct 17 2019, 12:07 PM
This revision is now accepted and ready to land.Oct 17 2019, 12:07 PM
Clément Foucault (fclem) added inline comments.Oct 17 2019, 12:08 PM
source/blender/draw/modes/object_mode.c
2721

You can use DRW_shgroup_uniform_vec3_copy for theses. Might be faster and less error prone.

Jeroen Bakker (jbakker) updated this revision to Diff 19090.Oct 17 2019, 12:12 PM

Use uniform_copy

Harbormaster completed remote builds in B5403: Diff 19090.Oct 17 2019, 12:12 PM
Jeroen Bakker (jbakker) marked an inline comment as done.Oct 17 2019, 12:13 PM
Closed by commit rB9d228c688d71: Volumetric: Debug Voxel Size and Location (authored by Jeroen Bakker (jbakker)). · Explain WhyOct 17 2019, 12:18 PM
This revision was automatically updated to reflect the committed changes.
Jeroen Bakker (jbakker) added a commit: rB9d228c688d71: Volumetric: Debug Voxel Size and Location.
Jeroen Bakker (jbakker) added a commit: rB78f8270ad3f3: Volumetric: Debug Voxel Size and Location.Oct 17 2019, 12:20 PM

Revision Contents
Changeset List

PathSize
source/
blender/
draw/
modes/
18 lines
shaders/
15 lines

Diff 19091

View Options

source/blender/draw/modes/object_mode.c

Loading...
View Options

source/blender/draw/modes/shaders/volume_velocity_vert.glsl

Loading...