Fix T70873: Pivot Center calculation ignores mirror elements
AbandonedPublic
Actions

Authored by Germano Cavalcante (mano-wii) on Oct 16 2019, 5:13 PM.

Details

Reviewers

Campbell Barton (campbellbarton)

Maniphest Tasks

T70873: Pivot Center doesn't compute mirror elements

Summary

Since rB3bd4f229beb, mirror elements are no longer` TransData`.
Thus, some values computed with the TransData array now ignore mirror elements.
The solution is to duplicate the logic to use mirror elements in each case.
I don't like the idea of duplicating code but this solution has advantages in peformanse and memory.

The best solution would be to rearrange and make separate arrays for each case (instead of adding more members to TransData).
But that would be a huge refactor.

Ref T70873

Diff Detail

Repository

rB Blender

Branch

master

Build Status

Buildable 5389
Build 5389: arc lint + arc unit

Event Timeline

Germano Cavalcante (mano-wii) created this revision.Oct 16 2019, 5:13 PM

Harbormaster completed remote builds in B5388: Diff 19064.Oct 16 2019, 5:13 PM

Fix: calculate center of unselected mirror elements

Harbormaster completed remote builds in B5389: Diff 19065.Oct 16 2019, 5:20 PM

Germano Cavalcante (mano-wii) retitled this revision from Fix T70873: Pivot Center doesn't compute mirror elements to Fix T70873: Pivot Center calculation ignores mirror elements.Oct 18 2019, 1:41 PM

Germano Cavalcante (mano-wii) abandoned this revision.Jun 8 2020, 1:29 PM