Differential D6088

Fix T70866: Missing PBVH updates after mask undo
ClosedPublic
Actions

Authored by Pablo Dobarro (pablodp606) on Oct 17 2019, 6:01 PM.

Details

Reviewers

Jeroen Bakker (jbakker)

Maniphest Tasks

T70866: Masking tools was a bug after Undo

Commits

rB90fd75c869c0: Fix T70866: Missing PBVH updates after mask undo

Summary

With the latest changes, the PBVH needs extra flags each time the mask is
modified to keep the internal fully_masked and fully_unmasked node flags
updated.

I can refactor this area to use the SCULPT_UPDATE flags after adding the
color and face map data in 2.82

Diff Detail

Repository

rB Blender

Branch

T70866 (branched from master)

Build Status

Buildable 5406
Build 5406: arc lint + arc unit

Event Timeline

Pablo Dobarro (pablodp606) created this revision.Oct 17 2019, 6:01 PM

Harbormaster completed remote builds in B5406: Diff 19096.Oct 17 2019, 6:01 PM

Pablo Dobarro (pablodp606) added a reviewer: Jeroen Bakker (jbakker).Oct 17 2019, 6:02 PM

Jeroen Bakker (jbakker) requested changes to this revision.Oct 30 2019, 8:36 AM

Jeroen Bakker (jbakker) added inline comments.

source/blender/editors/sculpt_paint/sculpt_undo.c
90	Is this line used at all?

This revision now requires changes to proceed.Oct 30 2019, 8:36 AM

Review Update

Harbormaster completed remote builds in B5492: Diff 19276.Oct 30 2019, 3:45 PM

Jeroen Bakker (jbakker) accepted this revision.Oct 30 2019, 4:05 PM

This revision is now accepted and ready to land.Oct 30 2019, 4:05 PM

Closed by commit rB90fd75c869c0: Fix T70866: Missing PBVH updates after mask undo (authored by Pablo Dobarro (pablodp606)). · Explain WhyOct 31 2019, 2:32 PM

This revision was automatically updated to reflect the committed changes.

Pablo Dobarro (pablodp606) added a commit: rB90fd75c869c0: Fix T70866: Missing PBVH updates after mask undo.

Revision Contents
Changeset List

Path

Size

source/

blender/

editors/

sculpt_paint/

sculpt_undo.c

8 lines

Diff 19096

View Options

source/blender/editors/sculpt_paint/sculpt_undo.c

Fix T70866: Missing PBVH updates after mask undoClosedPublicActions