While flipping the header to bottom works in the MCE (because MCE doesnt
allow overlapping UI) we need to take the regions visible rect into
account for the Image Editor.
Details
Details
Diff Detail
Diff Detail
- Repository
- rB Blender
- Branch
- T70905 (branched from master)
- Build Status
Buildable 5409 Build 5409: arc lint + arc unit
Event Timeline
| source/blender/editors/include/ED_screen.h | ||
|---|---|---|
| 407 | Why to remove const? Is this because some underlying functions don't get const pointer? Would prefer to add const to those. | |
| source/blender/editors/mask/mask_draw.c | ||
| 806 | Comment is a full sentence, starting with capital letter and ending with a fullstop. | |
| source/blender/editors/screen/area.c | ||
| 3342 | Same as above. | |
| 3383 | Same as above. | |
| source/blender/editors/space_image/image_draw.c | ||
| 904 | Same as above. | |
| source/blender/editors/include/ED_screen.h | ||
|---|---|---|
| 407 | Yes, this was because both ED_region_cache_draw_background and ED_region_cache_draw_cached_segments would now use ED_region_visible_rect. "Constifying" ED_region_visible_rect is not possible afaict (it alters ar->runtime.visible_rect) Alternative: let callers of ED_region_cache_draw_background and ED_region_cache_draw_cached_segments calculate region_bottom prior (call ED_region_visible_rect prior) and pass that in? (doesnt look pretty either...) | |
Comment Actions
Just noticed that we also need to adjust the clickable "scrubbing area" [atm. this isnt scrubbable if the header is flipped to the bottom]
Comment Actions
- correct clickable scubbing area (poll for frame_change) in the Image Editor when header is flipped to bottom
- correct clickable scubbing area (poll for frame_change) in the Image Editor and the MovieClip Editor not taking UI_DPI_FAC into account