Differential D6094
Fix T65076: Missing EasingType implementation on the Dopesheet Authored by Philipp Oeser (lichtwerk) on Oct 18 2019, 5:02 PM. Tags Subscribers None Tokens
Details EasingType was implemented rBdaccaa713b6e for the GraphEditor (but never If you can select Easing Mode in the DopeSheet, then you should also be This is just monkey-porting existing code from the GraphEditor to the Re: T65076
Diff Detail
Event TimelineComment Actions This functionality has been copied too many times already, yet another copy shouldn't be needed. How about a function like this? void ANIM_animdata_apply_callback(bAnimContext *ac, KeyframeEditFunc set_cb)
{
ListBase anim_data = {NULL, NULL};
bAnimListElem *ale;
int filter;
/* filter data */
filter = (ANIMFILTER_DATA_VISIBLE | ANIMFILTER_LIST_VISIBLE | ANIMFILTER_FOREDIT |
ANIMFILTER_NODUPLIS);
ANIM_animdata_filter(ac, &anim_data, filter, ac->data, ac->datatype);
for (ale = anim_data.first; ale; ale = ale->next) {
ANIM_fcurve_keyframes_loop(NULL, ale->key_data, NULL, set_cb, calchandles_fcurve);
ale->update |= ANIM_UPDATE_DEFAULT;
}
ANIM_animdata_update(ac, &anim_data);
ANIM_animdata_freelist(&anim_data);
}That should then be able to replace all the duplicates by calls like: static void setipo_action_keys(bAnimContext *ac, short mode)
{
ANIM_animdata_apply_callback(ac, ANIM_editkeyframes_ipo(mode));
}Comment Actions I've reduced code duplication in the way I described above. @Philipp Oeser (lichtwerk) do you agree with this? If so, I'll commit it. Comment Actions Thx! |