source/blender/editors/gpencil/gpencil_primitive.c
434	Is really working the Wheel? I use the wheel but the number doesn't change (at least in the UI)
1352	Remove this line.
1708	Do we have control points for this new polyline? I don't see anything..is it a bug or not?

Antonio Vazquez (antoniov) added reviewers: Antonio Vazquez (antoniov), Matias Mendiola (mendio).Oct 18 2019, 10:56 PM

Antonio Vazquez (antoniov) added inline comments.Oct 18 2019, 10:59 PM

release/scripts/presets/keyconfig/keymap_data/blender_default.py
5805	Do we need Shift and Alt keymaps?

Fix comments

Harbormaster completed remote builds in B5416: Diff 19114.Oct 18 2019, 11:11 PM

Missed comment

Harbormaster completed remote builds in B5417: Diff 19115.Oct 18 2019, 11:15 PM

Charlie Jolly (charlie) marked an inline comment as not done.Oct 18 2019, 11:20 PM

Charlie Jolly (charlie) added inline comments.

release/scripts/presets/keyconfig/keymap_data/blender_default.py
5805	Shift yes but not alt

Add back mousewheel support to increase number of points per line
Add back control point to show last pivot point

Harbormaster completed remote builds in B5418: Diff 19117.Oct 18 2019, 11:36 PM

Antonio Vazquez (antoniov) accepted this revision.Oct 18 2019, 11:40 PM

This revision is now accepted and ready to land.Oct 18 2019, 11:40 PM

We have not implemented the F and Shift+F keys in this primitive and to be consistent with other primitives we need both.

Add back FKEY for brush size

Harbormaster completed remote builds in B5420: Diff 19121.Oct 19 2019, 12:57 PM

In D6097#140421, @Antonio Vazquez (antoniov) wrote:

We have not implemented the F and Shift+F keys in this primitive and to be consistent with other primitives we need both.

The ESC key to cancel is missing too

This revision now requires changes to proceed.Oct 19 2019, 1:20 PM

Add back ESC key to cancel

Harbormaster completed remote builds in B5421: Diff 19122.Oct 19 2019, 1:28 PM

Matias Mendiola (mendio) accepted this revision.Oct 19 2019, 1:34 PM

This revision is now accepted and ready to land.Oct 19 2019, 1:34 PM

Closed by commit rBc2a2cd13be2f: GPencil: Primitive: Polyline Tool (authored by Charlie Jolly (charlie)). · Explain WhyOct 19 2019, 1:38 PM

This revision was automatically updated to reflect the committed changes.

Charlie Jolly (charlie) added a commit: rBc2a2cd13be2f: GPencil: Primitive: Polyline Tool.

For me all is fine now and you can commit to master.

GPencil: Primitive: Polyline Tool
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 19115

release/scripts/presets/keyconfig/keymap_data/blender_default.py

release/scripts/startup/bl_ui/properties_paint_common.py

release/scripts/startup/bl_ui/space_toolsystem_toolbar.py

release/scripts/startup/bl_ui/space_view3d.py

source/blender/editors/gpencil/gpencil_intern.h

source/blender/editors/gpencil/gpencil_primitive.c

GPencil: Primitive: Polyline ToolClosedPublicActions