Page MenuHome
Differential D6120

Separate operators (mesh/curve/armature/gpencil): take user preferences into account for duplicating actions
ClosedPublic
Actions

Authored by Philipp Oeser (lichtwerk) on Oct 23 2019, 12:58 PM.

Details

Reviewers
Campbell Barton (campbellbarton)
Bastien Montagne (mont29)
Sybren A. Stüvel (sybren)
Group Reviewers
Animation & Rigging
Maniphest Tasks
T71038: keyframe animation for 2 objects created by separating geometry remains linked
Commits
rBb454a1223317: Separate operators (mesh/curve/armature/gpencil): take user preferences into…
Summary

Previously actions remained linked after duplication, now this is based on the User Preferences (PreferencesEdit.use_duplicate_action).

note: default is ON here, so this changes default behavior of separate operators.

First intuition was to respect _all_ preferences here (e.g. also duplicating materials if chosen in the User Preferences) but after consideration this is probably not what the User would expect from such modeling opertions (e.g. separate by loose parts resulting in possibly many duplicate materials)

Fixes T71038

Diff Detail

Repository
rB Blender
Branch
T71038 (branched from master)
Build Status
Buildable 6810
Build 6810: arc lint + arc unit

Event Timeline

Philipp Oeser (lichtwerk) created this revision.Oct 23 2019, 12:58 PM
Harbormaster completed remote builds in B5444: Diff 19171.Oct 23 2019, 12:58 PM
Campbell Barton (campbellbarton) added a comment.EditedOct 24 2019, 10:51 AM

Making the case for current functionality.

It's possible some users run into problems with this change, if they have duplicate materials enabled for e.g. They might not expect separate loose parts to give them many different materials.

It's also less predictable to use operators from scripts when they're using preferences you might not expect.

OTOH, duplicating actions is what users probably expect in most cases, so we could select the flags used from the preferences.

Unless there is a good argument for following material & other options, think this is more predictable.

USER_DUP_MESH | (U.dupflag & USER_DUP_ACT)

Philipp Oeser (lichtwerk) mentioned this in T71723: VSE (2.81): Copy-pasted meta strips lose all key frames.Nov 21 2019, 10:33 AM
Philipp Oeser (lichtwerk) mentioned this in T36263: Pasted strip doesnt have F-Curve keyframes from the original.Nov 25 2019, 10:01 AM
Philipp Oeser (lichtwerk) updated this revision to Diff 22127.Feb 27 2020, 2:05 PM
  • only do this for actions
  • also do this for curves
Harbormaster completed remote builds in B6810: Diff 22127.Feb 27 2020, 2:06 PM
Philipp Oeser (lichtwerk) retitled this revision from MESH_OT_separate: take user preferences into account for what data to duplicate along to Separate operators (mesh/curve): take user preferences into account for duplicating actions.Feb 27 2020, 2:08 PM
Philipp Oeser (lichtwerk) edited the summary of this revision. (Show Details)
Philipp Oeser (lichtwerk) added a reviewer: Animation & Rigging.
Philipp Oeser (lichtwerk) added a comment.Feb 27 2020, 2:29 PM

note:

  • would also do this for armatures, but armature separate operator seem to be broken (happened somewhere between 2.81a and 2.82 - will report separately)
  • surfaces already done along with curves
  • greasepencil object could be done as well
Philipp Oeser (lichtwerk) added a comment.Feb 27 2020, 2:39 PM

was also mentioned in T55365: Blender development todo list -- Animation System

Philipp Oeser (lichtwerk) updated this revision to Diff 22136.Feb 27 2020, 4:19 PM

also do this for separating bones (to test, you might want to apply D6949 as well since separating bones is broken atm.)

Harbormaster completed remote builds in B6816: Diff 22136.Feb 27 2020, 4:19 PM
Philipp Oeser (lichtwerk) updated this revision to Diff 22138.Feb 27 2020, 4:27 PM

also do this for gpencil object actions

Harbormaster completed remote builds in B6818: Diff 22138.Feb 27 2020, 4:27 PM
Philipp Oeser (lichtwerk) retitled this revision from Separate operators (mesh/curve): take user preferences into account for duplicating actions to Separate operators (mesh/curve/armature/gpencil): take user preferences into account for duplicating actions.Feb 27 2020, 4:48 PM
Philipp Oeser (lichtwerk) added a comment.Feb 28 2020, 3:31 PM

Test file

T71038.blend614 KBDownload

Sybren A. Stüvel (sybren) accepted this revision.EditedFeb 28 2020, 3:36 PM
Sybren A. Stüvel (sybren) added a subscriber: Sybren A. Stüvel (sybren).

LGTM, just some tiny nags.

source/blender/editors/armature/armature_relations.c
670 ↗(On Diff #22138)

Comments should be a sentence, so start with a capital.

source/blender/editors/gpencil/gpencil_edit.c
4099 ↗(On Diff #22138)

IMO this newline can be removed, as the lines above & below it are tightly connected.

This revision is now accepted and ready to land.Feb 28 2020, 3:36 PM
Closed by commit rBb454a1223317: Separate operators (mesh/curve/armature/gpencil): take user preferences into… (authored by Philipp Oeser (lichtwerk)). · Explain WhyMar 3 2020, 10:05 AM
This revision was automatically updated to reflect the committed changes.
Philipp Oeser (lichtwerk) added a commit: rBb454a1223317: Separate operators (mesh/curve/armature/gpencil): take user preferences into….
Philipp Oeser (lichtwerk) mentioned this in T83701: objects color issue when creating on object from faces of another.Dec 14 2020, 11:29 AM

Revision Contents
Changeset List

PathSize
source/
blender/
editors/
curve/
7 lines
mesh/
8 lines

Diff 22127

View Options

source/blender/editors/curve/editcurve.c

Loading...
View Options

source/blender/editors/mesh/editmesh_tools.c

Loading...