Fix T50148: Header: Wrong rounding when moving frames
ClosedPublic
Actions

Authored by Germano Cavalcante (mano-wii) on Oct 27 2019, 1:11 AM.

Details

Reviewers

Campbell Barton (campbellbarton)

Maniphest Tasks

T50148: Wrong rounding when moving frames
T5014: xml export of Yafray render file not working.

Commits

rBce0db668ec04: Fix T50148: Header: Wrong rounding when moving frames

Summary

As described in the report, the snap value in frames does not match the value described in the header.
The solution was to deduplicate the code and use the same logic used to calculate individual elements in t->values_final[0].

Ref T50148

Diff Detail

Repository

rB Blender

Branch

master

Build Status

Buildable 5460
Build 5460: arc lint + arc unit

Event Timeline

Germano Cavalcante (mano-wii) created this revision.Oct 27 2019, 1:11 AM

Harbormaster completed remote builds in B5460: Diff 19203.Oct 27 2019, 1:11 AM

Germano Cavalcante (mano-wii) retitled this revision from Fix T5014: Wrong rounding when moving frames to Fix T50148: Wrong rounding when moving frames.Oct 27 2019, 1:12 AM

Germano Cavalcante (mano-wii) edited the summary of this revision. (Show Details)

Germano Cavalcante (mano-wii) added a task: T50148: Wrong rounding when moving frames.

Germano Cavalcante (mano-wii) retitled this revision from Fix T50148: Wrong rounding when moving frames to Fix T50148: Header: Wrong rounding when moving frames.Oct 28 2019, 12:56 PM

Campbell Barton (campbellbarton) accepted this revision.Oct 28 2019, 1:08 PM

Campbell Barton (campbellbarton) added inline comments.

source/blender/editors/transform/transform_snap.c
1328	Prefer doxy separators - see: `BLI_ghash.c`, they have the advantage that they group code blocks.
1564	No need for `bool` return value, it's ignored.
1565	autosnap can be `eAnimEdit_AutoSnap`