This patch adds the ability to delete the Proxy of the active sequencer strip.
Details
Details
Diff Detail
Diff Detail
- Repository
- rB Blender
- Branch
- DeleteProxy (branched from master)
- Build Status
Buildable 6133 Build 6133: arc lint + arc unit
Event Timeline
Comment Actions
This action can not be undone, so confirmation dialog must be used.
"All proxy files for this strip will be permanently removed. Do you want to continue?"
Or something in that note.
| release/scripts/startup/bl_operators/sequencer.py | ||
|---|---|---|
| 384–387 | It doesn't seem, that this operator requires invoke method, it could be removed. | |
| 399 | I mean it may be correct naming scheme, but it doesn't look right in context of this file. Other editors have this quite mixed, so I don't know. Don't want to nitpick too much, but on the other hand I want to point to potential issues... | |
| 415–416 | Please use a bit more descriptive names | |
| 426 | also descriptive names | |
This comment was removed by Peter Fog (tintwotin).
| release/scripts/startup/bl_operators/sequencer.py | ||
|---|---|---|
| 399 | Maybe it is time to rename these operators to be in consistency with 2.8 class naming? SequencerCrossfadeSounds, SequencerCutMulticam, SequencerDeinterlaceSelectedMovies, SequencerFadesClear, SequencerFadesAdd, | |
Comment Actions
record_run_no_gaps.blen_tc being left in the folder is what happens when deleted proxy in the clip editor
Comment Actions
- Fix bug when multiple strips sellected
- Fix bug where record_run_no_gaps.blen_tc and folders aren't deleted
- Added Option: Delete Active selected strip proxy
| release/scripts/startup/bl_operators/sequencer.py | ||
|---|---|---|
| 399 | I can fix the rest of the naming Scheme in another patch | |
Comment Actions
Digging through WM API, I realized, that the invoke method, was actually used as a confirmation.
It was quite poor in execution, so it would be better if we could explain to user, what is going to happen. Not quite sure if that is possible
Comment Actions
I will look into that.
Deleting proxy in the clip editor doesn’t have a confirmation and has the invoke
| release/scripts/startup/bl_operators/sequencer.py | ||
|---|---|---|
| 378–385 | This doesn't seem necessary or consistent with other operators. Nearly any operator that uses the selection could also use the active-only, however we don't provide this option. | |
| 393–396 | Poll function should not loop over selection, it's likely to backfire when drawing the interface and slow down interaction. Also, was this tested? it's accessing self which isn't defined in classmethods. | |
| 417–468 | This copy-pastes code from clip.py, did you look into sharing logic between these two functions? It seems like this is a case it could be done. | |
| release/scripts/startup/bl_operators/sequencer.py | ||
|---|---|---|
| 378–385 | The built-in proxy function allows for both building of the active strip and building of proxies for selected strips. Currently there is a Build Proxies function in the menu - so there should also be a delete proxies function. In operators executed from the VSE Menus pretty much all operate on selection, whereas operators executed from the Strip tab in the sidebar are typically only affecting the active strip unless +alt is pressed. If the following reworking of the current proxy panel, which separates the proxy functions into Active in the Strip panel and Selection in the Proxies & Cache tab, should be accepted, then separated delete proxy/proxies will also be necessary: https://developer.blender.org/D6077 So for those reasons, I suggested that Eitan added options for both active and selected strips. | |
| release/scripts/startup/bl_operators/sequencer.py | ||
|---|---|---|
| 417–468 | I could definitely share code but which file should I put it in | |
| release/scripts/startup/bl_operators/sequencer.py | ||
|---|---|---|
| 417–468 | For the moment you could make a staticmethod on the class CLIP_OT_delete_proxy in clip.py, import and call that. Later we could move to ./release/scripts/modules/bpy_extras/video_utils.py. | |
| release/scripts/startup/bl_operators/sequencer.py | ||
|---|---|---|
| 377–378 | These should be set in the classes execute function. Also use Python naming convention (lower case w/ underscore separators). | |
| release/scripts/startup/bl_operators/sequencer.py | ||
|---|---|---|
| 417–468 | I can put it in ./release/scripts/modules/bpy_extras/video_utils.py right now | |
Comment Actions
Can you look at D6171 it is a python API that would make using the same function much simpler.
Comment Actions
Proxy Custom Directory doesn't work
Proxy Custom File deletes BL_proxy directory, not custom file
Per project setting deletes BL_proxy directory not per-project directory
I haven't tested clip editor, not sure if it is similar there.
Could this operate on selected_sequences rather than active_sequence?
Otherwise looks good.
Comment Actions
I found why custom directory isn’t working.
I am using active sequence because that is consistent with the rest of the ui.
Comment Actions
In D6139#157778, @Eitan Traurig (EitanSomething) wrote:
I found why custom directory isn’t working.
I am using active sequence because that is consistent with the rest of the ui.
class SEQUENCER_MT_proxy(Menu):
bl_label = "Proxy"
def draw(self, _context):
layout = self.layout
layout.operator("sequencer.rebuild_proxy")
layout.operator("sequencer.delete_proxy")in this menu sequencer.rebuild_proxy will work on selected strips
Comment Actions
Found a bunch of other problems with the implementation.I need to add a couple more checks.
I think we need to rework the internals of all of the sequence objects because they are a mess and are inconsistent.
Comment Actions
- Fix custom directory bug
- Fix error with image strips
- Fix undistorted files not getting deleted
There is definitely a lot of cleanup that can be done to this code.