Fix T68018: Crash on building movie proxy
ClosedPublic
Actions

Authored by Richard Antalik (ISS) on Oct 29 2019, 5:37 AM.

Details

Reviewers

Sergey Sharybin (sergey)

Maniphest Tasks

T68018: Being able to set the same location of proxies to source is not allowed in the filesystem

Commits

rB8ab6ef30ab28: Fix T68018: Crash on building movie proxy

Summary

Crash happens, when setting custom dir to location of source file itself.
This results in attempt to create directory with the same name as source file.

Fix works in VSE, aditional fixes may be needed in other editors.

Diff Detail

Repository: rB Blender

Event Timeline

Richard Antalik (ISS) created this revision.Oct 29 2019, 5:37 AM

Harbormaster completed remote builds in B5479: Diff 19242.Oct 29 2019, 5:37 AM

Campbell Barton (campbellbarton) added a subscriber: Campbell Barton (campbellbarton).Oct 29 2019, 11:50 AM

Campbell Barton (campbellbarton) added inline comments.

source/blender/editors/space_sequencer/sequencer_edit.c
180	Can pass `ReportList` instead of reports.

Pass ReportList instead of wmOperator

Harbormaster completed remote builds in B5487: Diff 19260.Oct 30 2019, 4:28 AM

If it fixes the issue go ahead.

This revision is now accepted and ready to land.Oct 30 2019, 10:28 AM

Closed by commit rB8ab6ef30ab28: Fix T68018: Crash on building movie proxy (authored by Richard Antalik (ISS)). · Explain WhyNov 3 2019, 5:51 AM

This revision was automatically updated to reflect the committed changes.

Richard Antalik (ISS) added a commit: rB8ab6ef30ab28: Fix T68018: Crash on building movie proxy.

I have build error:
/var/tmp/portage/media-gfx/blender-2.81.9999/work/blender-2.81.9999/source/blender/blenkernel/intern/sequencer.c: In function ‘BKE_sequencer_proxy_rebuild_context’:
/var/tmp/portage/media-gfx/blender-2.81.9999/work/blender-2.81.9999/source/blender/blenkernel/intern/sequencer.c:2110:5: error: ‘return’ with no value, in function returning non-void [-Werror=return-type]

@Yury (thankjura) this has been fixed in master.

bartus sz (bartus) added a subscriber: bartus sz (bartus).Nov 4 2019, 2:27 PM

bartus sz (bartus) added inline comments.

source/blender/blenkernel/intern/sequencer.c
2110	`gcc-9` complains about `error: ‘return’ with no value, in function returning non-void [-Werror=return-type]` It should return with `false/true`