Pose brush: Smooth Iterations Brush Property
ClosedPublic
Actions

Authored by Pablo Dobarro (pablodp606) on Oct 30 2019, 5:32 PM.

Details

Reviewers

Jeroen Bakker (jbakker)

Commits

rB186bd1759f05: Pose brush: Smooth Iterations Brush Property

Summary

The smooth iterations of the pose factor were hardcoded to 4. This works fine in most situations when you are posing a low poly mesh, which is the main use case of this tool. I added the smooth iterations as a brush property in case you need to pose a high poly mesh directly without producing artifacts.

Diff Detail

Repository: rB Blender

Event Timeline

Pablo Dobarro (pablodp606) created this revision.Oct 30 2019, 5:32 PM

Harbormaster completed remote builds in B5500: Diff 19284.Oct 30 2019, 5:32 PM

Pablo Dobarro (pablodp606) edited the summary of this revision. (Show Details)Oct 30 2019, 5:33 PM

Pablo Dobarro (pablodp606) added a reviewer: Jeroen Bakker (jbakker).

Pablo Dobarro (pablodp606) added a project: BF Blender (2.82).

Brandon (Brandon777) awarded a token.Oct 30 2019, 9:05 PM

TheRedWaxPolice (TheRedWaxPolice) awarded a token.Oct 30 2019, 9:46 PM

Kenn Nyström (Frozen_Death_Knight) awarded a token.Oct 30 2019, 10:09 PM

srikanth (Alrob) awarded a token.Oct 31 2019, 3:38 AM

Metin Seven (MetinSeven) awarded a token.Nov 1 2019, 10:27 AM

Joseph Brandenburg (TheAngerSpecialist) awarded a token.Nov 5 2019, 11:13 PM

Note I didn't see any migration code for existing curves. Is this needed?

source/blender/editors/sculpt_paint/sculpt.c
5708–5713	Where does the 1.5f come from. Please add comment
5708–5713	Use float not integers when the rest is a float. Compilers might add an additional not needed conversion.

This revision now requires changes to proceed.Nov 14 2019, 3:19 PM

Review update, Add versioning code

Harbormaster completed remote builds in B5683: Diff 19638.Nov 14 2019, 7:52 PM

The current way of dealing with the PBVH nodes is not the best, but I will improve it after finishing the patch for the pose brush with inverse kinematics, which needs to store multiple pose factors per vertex at the same time.

Jeroen Bakker (jbakker) requested changes to this revision.Nov 15 2019, 3:56 PM

Jeroen Bakker (jbakker) added inline comments.