This patch uses RK4 integration in the grab kelvinlets. In theory this is the right way to use them, but I think I prefer the old behavior when doing just a single evaluation for the grab brushes. Maybe there is something wrong with the implementation.
Before
After
Details
Details
- Reviewers
Jeroen Bakker (jbakker)
Diff Detail
Diff Detail
- Repository
- rB Blender
- Branch
- elastic-deform-integrate-grab (branched from master)
- Build Status
Buildable 5685 Build 5685: arc lint + arc unit
Event Timeline
Comment Actions
Not sure how we should proceed with this patch? So perhaps have more feedback from users.
| source/blender/editors/sculpt_paint/sculpt.c | ||
|---|---|---|
| 3389 | we should add a the link to the original paper and add its name as numbers may get outdated more quickly and does not tell us a thing https://graphics.pixar.com/library/Kelvinlets/gradDerivation.pdf | |
| 3565 | so grab_delta is not a delta, but a direction. or this is something to investigate or use the correct namings. | |
Comment Actions
The Grease Pencil Team was also interested in these brushes and the Kelvinlet formulas are the same for mesh sculpting and Grease Pencil.
@Antonio Vazquez (antoniov) Maybe we can take a look at this during 2.82, move the Kelvinlets to a place where can be reused in both sculpting systems and check if everything is correct?
Comment Actions
It is not clear to me if this patch needs to be reviewed or can be marked as obsolete. At least it should be updated to match the latest changes...