Fix T59271: Curves with Extrude still show curve
ClosedPublic
Actions

Authored by Philipp Oeser (lichtwerk) on Nov 1 2019, 1:28 PM.

Details

Reviewers

Jeroen Bakker (jbakker)
Clément Foucault (fclem)

Maniphest Tasks

T62668: Cannot select beveled curves in the viewport wherever the bevel is not visible if bevel start and/or end are set
T59271: Curves with Extrude still show curve

Commits

rB6da097136cf4: Fix T59271: Curves with Extrude still show curve

Summary

Compared to 2.79, this also has the benifit of actually showing the curve
again if you set both bevel start and end to 0.0 for example.

Diff Detail

Repository: rB Blender

Event Timeline

Philipp Oeser (lichtwerk) created this revision.Nov 1 2019, 1:28 PM

Harbormaster completed remote builds in B5517: Diff 19318.Nov 1 2019, 1:28 PM

LGTM, can only imagine that the curve_cache can be NULL.

check curve_cache available

Harbormaster completed remote builds in B5676: Diff 19629.Nov 14 2019, 5:09 PM

Jeroen Bakker (jbakker) accepted this revision.Jan 7 2020, 3:36 PM

This revision is now accepted and ready to land.Jan 7 2020, 3:36 PM

Sorry, I accepted it, but it needs to be converted to the new overlay engine....

This revision now requires changes to proceed.Jan 7 2020, 3:37 PM

convert to overlay engine

Harbormaster completed remote builds in B6449: Diff 21304.Jan 31 2020, 8:25 PM

Philipp Oeser (lichtwerk) edited the summary of this revision. (Show Details)Jan 31 2020, 8:26 PM

Clément Foucault (fclem) accepted this revision.Feb 11 2020, 7:04 PM

This revision was not accepted when it landed; it landed in state Needs Review.Feb 12 2020, 6:46 PM

Closed by commit rB6da097136cf4: Fix T59271: Curves with Extrude still show curve (authored by Philipp Oeser (lichtwerk)). · Explain Why

This revision was automatically updated to reflect the committed changes.

Philipp Oeser (lichtwerk) added a commit: rB6da097136cf4: Fix T59271: Curves with Extrude still show curve.

Revision Contents
Changeset List

Path

Size

source/

blender/

draw/

engines/

overlay/

overlay_wireframe.c

5 lines

Diff 21663

View Options

source/blender/draw/engines/overlay/overlay_wireframe.c

Fix T59271: Curves with Extrude still show curveClosedPublicActions