Differential D6184

Fix T71259: Array Modifier Performance is slow
ClosedPublic
Actions

Authored by Sergey Sharybin (sergey) on Nov 4 2019, 2:17 PM.

Tags

None

Subscribers

None

Details

Reviewers

Germano Cavalcante (mano-wii)
Bastien Montagne (mont29)

Commits

rBa1747b058d7f: Fix T71259: Array Modifier Performance is slow

Summary

Was happening when object transform is animated.

Caused by overly aggressive dependency construction introduced a
while back in rB9d4129eee649: we shouldn't add dependencies unless
we really need them.

The transform is totally needed for an offset object, but I can't
see why transform is needed for the cap objects: those seems to be
only used as a mesh, without transform.

Diff Detail

Repository

Branch

fix_T71259 (branched from master)

Build Status

Buildable 5544
Build 5544: arc lint + arc unit

Event Timeline

Sergey Sharybin (sergey) created this revision.Nov 4 2019, 2:17 PM

Harbormaster completed remote builds in B5544: Diff 19380.Nov 4 2019, 2:17 PM

I have tested here and indeed the position of the meshes used as cap does not interfere with the modifier (only their geometry).

Bastien Montagne (mont29) edited the summary of this revision. (Show Details)Nov 4 2019, 4:12 PM

Yes, makes sense to me too.

This revision is now accepted and ready to land.Nov 4 2019, 4:15 PM

Closed by commit rBa1747b058d7f: Fix T71259: Array Modifier Performance is slow (authored by Sergey Sharybin (sergey)). · Explain WhyNov 5 2019, 3:26 PM

This revision was automatically updated to reflect the committed changes.

Sergey Sharybin (sergey) added a commit: rBa1747b058d7f: Fix T71259: Array Modifier Performance is slow.

Revision Contents
Changeset List

Path

Size

source/

blender/

modifiers/

intern/

11 lines

Diff 19380

source/blender/modifiers/intern/MOD_array.c

Loading...