Page MenuHome
Differential D6186

Fix 2D paint antialiasing offset
ClosedPublic
Actions

Authored by Pablo Dobarro (pablodp606) on Nov 4 2019, 3:05 PM.

Details

Reviewers
Jeroen Bakker (jbakker)
Commits
rBa58c1d4497db: Fix 2D paint antialiasing offset
Summary

The AA offset should be substracted, not added. I think this was
introduced when I refactored the code in a code review.

Diff Detail

Repository
rB Blender
Branch
fix-paint-aa-bug (branched from master)
Build Status
Buildable 5547
Build 5547: arc lint + arc unit

Event Timeline

Pablo Dobarro (pablodp606) created this revision.Nov 4 2019, 3:05 PM
Harbormaster completed remote builds in B5547: Diff 19385.Nov 4 2019, 3:05 PM
Pablo Dobarro (pablodp606) mentioned this in T71216: Brush Falloff in Texture Paint is broken now.Nov 4 2019, 3:08 PM
Pablo Dobarro (pablodp606) added a reviewer: Jeroen Bakker (jbakker).Nov 4 2019, 3:14 PM
Pablo Dobarro (pablodp606) added a project: BF Blender (2.81).
Jeroen Bakker (jbakker) accepted this revision.Nov 5 2019, 8:38 AM

Perhaps we could comment the code better. It is currently unclear what the units actually are.

This revision is now accepted and ready to land.Nov 5 2019, 8:38 AM
Closed by commit rBa58c1d4497db: Fix 2D paint antialiasing offset (authored by Pablo Dobarro (pablodp606)). · Explain WhyNov 6 2019, 7:23 PM
This revision was automatically updated to reflect the committed changes.
Pablo Dobarro (pablodp606) added a commit: rBa58c1d4497db: Fix 2D paint antialiasing offset.

Revision Contents
Changeset List

PathSize
source/
blender/
editors/
sculpt_paint/
4 lines

Diff 19385

View Options

source/blender/editors/sculpt_paint/paint_image_2d.c

Loading...