Page MenuHome

Sculpt: Sculpt template defaults
ClosedPublic

Authored by Pablo Dobarro (pablodp606) on Nov 11 2019, 6:02 PM.

Details

Summary

This patch includes all changes listed in T71366 except for the 2 column toolbar layout.

Diff Detail

Repository
rB Blender

Event Timeline

Brecht Van Lommel (brecht) added inline comments.
source/blender/blenloader/BLO_readfile.h
168–170 ↗(On Diff #19522)

The function here is to update the workspace only and should not affect meshes through mainvar.

Remove that parameter again, and instead do it in BLO_update_defaults_startup_blend with if (app_template && STREQ(app_template, "Sculpting")) {.

Pablo Dobarro (pablodp606) marked an inline comment as done.
  • Review Update
source/blender/blenloader/intern/versioning_defaults.c
368–372

This part editing meshes should not be inside the loop over workspaces. Meshes are not per-workspace so this makes no sense. They are part of an app template, which is why I suggested the app template test in my comment.

373–384

This part editing the screen was meant to stay in BLO_update_defaults_workspace.

Pablo Dobarro (pablodp606) marked 2 inline comments as done.
  • Review Update
This revision is now accepted and ready to land.Nov 13 2019, 5:19 PM
This revision was automatically updated to reflect the committed changes.