Page MenuHome
Differential D6228

Sculpt: New Clay Brush
ClosedPublic
Actions

Authored by Pablo Dobarro (pablodp606) on Nov 12 2019, 1:09 AM.
Tags
Subscribers
Maged afra (Maged_afra)
Tokens
"Love" token, awarded by plundh."Love" token, awarded by monio."Love" token, awarded by Maged_afra."Love" token, awarded by Zino."Burninate" token, awarded by Rubens91."Love" token, awarded by CandleComet."Doubloon" token, awarded by TheAngerSpecialist."Mountain of Wealth" token, awarded by TheRedWaxPolice."100" token, awarded by Frozen_Death_Knight."Love" token, awarded by andruxa696."Love" token, awarded by MetinSeven."100" token, awarded by tiagoffcruz."100" token, awarded by gobb_blend."Like" token, awarded by Alrob."Love" token, awarded by xrg."Mountain of Wealth" token, awarded by Brandon777.

Details

Reviewers
Jeroen Bakker (jbakker)
Commits
rB316107d4cd11: Sculpt: New Clay Brush
Summary

The previous Clay brush was similar to flatten. Now it has a different plane calculation and falloff, based on the position of the vertices before deforming them, so it feels more like adding clay to the model.

Diff Detail

Repository
rB Blender
Branch
clay-brush-exp (branched from master)
Build Status
Buildable 5630
Build 5630: arc lint + arc unit

Event Timeline

Pablo Dobarro (pablodp606) created this revision.Nov 12 2019, 1:09 AM
Harbormaster completed remote builds in B5630: Diff 19551.Nov 12 2019, 1:09 AM
Pablo Dobarro (pablodp606) edited the summary of this revision. (Show Details)Nov 12 2019, 1:11 AM
Pablo Dobarro (pablodp606) added a reviewer: Jeroen Bakker (jbakker).
Pablo Dobarro (pablodp606) added a project: BF Blender (2.82).
Brandon (Brandon777) awarded a token.Nov 12 2019, 1:21 AM
xrg (xrg) awarded a token.Nov 12 2019, 1:47 AM
srikanth (Alrob) awarded a token.Nov 12 2019, 3:20 AM
gobb_blend awarded a token.Nov 12 2019, 8:41 AM
Tiago Cruz (tiagoffcruz) awarded a token.Nov 12 2019, 9:38 AM
Metin Seven (MetinSeven) awarded a token.Nov 12 2019, 12:32 PM
Andrey (andruxa696) awarded a token.Nov 12 2019, 2:11 PM
Kenn Nyström (Frozen_Death_Knight) awarded a token.Nov 12 2019, 3:02 PM
TheRedWaxPolice (TheRedWaxPolice) awarded a token.Nov 12 2019, 7:45 PM
Joseph Brandenburg (TheAngerSpecialist) awarded a token.Nov 12 2019, 8:10 PM
CandleComet (CandleComet) awarded a token.Nov 15 2019, 3:37 AM
Jeroen Bakker (jbakker) requested changes to this revision.Nov 15 2019, 4:22 PM
Jeroen Bakker (jbakker) added inline comments.
source/blender/editors/sculpt_paint/sculpt.c
1736

Use floats

4690

We have macros for this. MIN2

4695

Use macros

4711

use macros

4715

use macros

4756

use floats

4757

use floats

This revision now requires changes to proceed.Nov 15 2019, 4:22 PM
Ruben Dario Espinel Mora (Rubens91) awarded a token.Nov 15 2019, 5:39 PM
Zino Guerr (Zino) awarded a token.Nov 15 2019, 9:07 PM
Zino Guerr (Zino) rescinded a token.
Zino Guerr (Zino) awarded a token.
Pablo Dobarro (pablodp606) updated this revision to Diff 19673.Nov 17 2019, 12:39 AM
Pablo Dobarro (pablodp606) marked 7 inline comments as done.
  • Review update
Harbormaster completed remote builds in B5702: Diff 19673.Nov 17 2019, 12:39 AM
Jeroen Bakker (jbakker) requested changes to this revision.Nov 18 2019, 2:42 PM
Jeroen Bakker (jbakker) added inline comments.
source/blender/editors/sculpt_paint/sculpt.c
4753–4767

Forgot to remove debug code?

This revision now requires changes to proceed.Nov 18 2019, 2:42 PM
Pablo Dobarro (pablodp606) updated this revision to Diff 19705.Nov 18 2019, 10:37 PM
Pablo Dobarro (pablodp606) marked an inline comment as done.
  • Remove debug code
Harbormaster completed remote builds in B5716: Diff 19705.Nov 18 2019, 10:40 PM
Maged afra (Maged_afra) awarded a token.Nov 19 2019, 12:28 AM
Maged afra (Maged_afra) added a subscriber: Maged afra (Maged_afra).
Jeroen Bakker (jbakker) accepted this revision.Nov 19 2019, 12:49 PM
This revision is now accepted and ready to land.Nov 19 2019, 12:49 PM
Bartosz Moniewski (monio) awarded a token.Nov 20 2019, 5:16 PM
Petter Lundh (plundh) awarded a token.Nov 20 2019, 7:45 PM
Closed by commit rB316107d4cd11: Sculpt: New Clay Brush (authored by Pablo Dobarro (pablodp606)). · Explain WhyNov 21 2019, 6:01 PM
This revision was automatically updated to reflect the committed changes.
Pablo Dobarro (pablodp606) added a commit: rB316107d4cd11: Sculpt: New Clay Brush.

Revision Contents
Changeset List

PathSize
source/
blender/
blenkernel/
intern/
3 lines
editors/
sculpt_paint/
165 lines

Diff 19551

View Options

source/blender/blenkernel/intern/brush.c

Loading...
View Options

source/blender/editors/sculpt_paint/sculpt.c

Loading...