Note, although this fix the immediate obvious issue there are still some
things that need fixing in this file browser.
Right now we store the window size when maximized, which we should not.
Differential D6259
Fix T70991 - File Explorer: Maximize window no the filename textbox on Windows Authored by Dalai Felinto (dfelinto) on Nov 14 2019, 10:43 PM.
Details
Note, although this fix the immediate obvious issue there are still some Right now we store the window size when maximized, which we should not.
Diff Detail
Event TimelineComment Actions Does this also work when switching between maximized and normal, multiple times? I.e. does the window stay a on-top-window with the minimize button disabled? If I remember correctly I disabled this call for dialog boxes to avoid messing with the window style in unwanted ways. I don't think we should store the maximized state. Maximizing is something you sometimes do quickly, or even unconsciously and you wouldn't want this to be saved. We'd probably have to store the normal state window size then too, as you'd want it to un-maximize to this size.
William, Brecht and I decided to not store the position for now, and just always open it in the center, unless there's good reason to do so. Storing the position might be a bit problematic with multi-monitor and hiDPI setups, remember that this is stored and should to work when opened on different machines. Comment Actions
Yes (current version anyways, previous version always had minimizedbox on).
Tackled separatedly: D6260 Comment Actions Note that the proposed fix still overrides the window style set when creating the dialog window, see https://developer.blender.org/diffusion/B/browse/master/intern/ghost/intern/GHOST_WindowWin32.cpp$272-278. So I looked into a different fix that doesn't do this and found an issue with our usage of the WS_CHILD style flag. This is actually what was causing this bug. Finding this would have taken much longer if you wouldn't have done the debugging and submitted this already, so at least your efforts weren't worthless :) Comment Actions My coding efforts are never worthless fear nothing. Thanks for the review and addressing this. |