BKE_nurb_type_convert now takes r_err_msg and is more specific in the error message...
ref T71672.
Details
Details
- Reviewers
Campbell Barton (campbellbarton) - Maniphest Tasks
- T71672: Can't change spline type to bezier
- Commits
- rB559d01e12949: Improve error message converting nurb to bezier
Diff Detail
Diff Detail
- Repository
- rB Blender
- Branch
- T71672 (branched from master)
- Build Status
Buildable 5721 Build 5721: arc lint + arc unit
Event Timeline
Comment Actions
While this change is OK, I think it would be better if this was set by the function it's self.
BKE_nurb_type_convert could take and optional const char **r_err_msg, and assign this in the case of an error.
This means if it ever returns false for another reason - it's less likely a developer doesn't notice the error needs updating elsewhere, or if we want to report the message elsewhere - we don't need to copy/paste messages about.
| source/blender/blenkernel/intern/curve.c | ||
|---|---|---|
| 4982 ↗ | (On Diff #21376) | This should check for NULL, since some callers pass in NULL & logic for setting errors may change over time. |