Paths

Table of Contentst

Differential D6284

Fix T69332: 'Reset to Default Value' on a custom string property crashes
ClosedPublic
Actions

Authored by Philipp Oeser (lichtwerk) on Nov 21 2019, 2:03 PM.

Tags

None

Subscribers

None

Details

Reviewers

Campbell Barton (campbellbarton)
Alexander Gavrilov (angavrilov)

Maniphest Tasks

T69332: Crash : attempting to reset a a custom property that has a string value crashes Blender

Commits

rB60e817693ce7: Fix T69332: 'Reset to Default Value' on a custom string property crashes
rBcfb7f508ce76: Fix T69332: 'Reset to Default Value' on a custom string property crashes

Diff Detail

Repository: rB Blender

Event Timeline

Philipp Oeser (lichtwerk) created this revision.Nov 21 2019, 2:03 PM

Harbormaster completed remote builds in B5736: Diff 19743.Nov 21 2019, 2:03 PM

Not sure this is correct, could you do:

StringPropertyRNA *sprop = (StringPropertyRNA *)rna_ensure_property(prop); as RNA_property_string_get_default does?

Yep, thats better, thx for the heads up!

Harbormaster completed remote builds in B5737: Diff 19744.Nov 21 2019, 2:50 PM

Campbell Barton (campbellbarton) accepted this revision.Nov 22 2019, 12:07 AM

This revision is now accepted and ready to land.Nov 22 2019, 12:07 AM

Closed by commit rBcfb7f508ce76: Fix T69332: 'Reset to Default Value' on a custom string property crashes (authored by Philipp Oeser (lichtwerk)). · Explain WhyNov 22 2019, 12:21 PM

This revision was automatically updated to reflect the committed changes.

Philipp Oeser (lichtwerk) added a commit: rBcfb7f508ce76: Fix T69332: 'Reset to Default Value' on a custom string property crashes.

Sergey Sharybin (sergey) added a commit: rB60e817693ce7: Fix T69332: 'Reset to Default Value' on a custom string property crashes.Dec 3 2019, 2:29 PM

Revision Contents
Changeset List

Path

Size

source/

blender/

makesrna/

intern/

2 lines

Diff 19774

source/blender/makesrna/intern/rna_access.c

Loading...