Details

Reviewers: None
Maniphest Tasks: T66304: Tools, Selection & Gizmo design

Summary

Note that this patch is to test out T66304: Tools, Selection & Gizmo design

Some parts of this patch are not well commented, this is not ready for final code review.

Gizmos for most tools.
Drag/Select tool option.
Use single popover which includes tool options for Drag selector. (currently uses two buttons).
Alt-LMB to activate the tool even when in selection mode.

Diff Detail

Repository

rBS Blender Staging

Branch

temp-tool-gizmo-generic

Build Status

Buildable 5787
Build 5787: arc lint + arc unit

Event Timeline

Campbell Barton (campbellbarton) created this revision.Nov 25 2019, 9:35 AM

Harbormaster completed remote builds in B5766: Diff 19814.Nov 25 2019, 9:35 AM

Campbell Barton (campbellbarton) added a task: T66304: Tools, Selection & Gizmo design.Nov 25 2019, 9:43 AM

Campbell Barton (campbellbarton) edited the summary of this revision. (Show Details)Nov 25 2019, 9:48 AM

Campbell Barton (campbellbarton) edited the summary of this revision. (Show Details)Nov 25 2019, 12:04 PM

Use popover

Harbormaster completed remote builds in B5774: Diff 19830.Nov 26 2019, 7:58 AM

Campbell Barton (campbellbarton) edited the summary of this revision. (Show Details)Nov 26 2019, 7:58 AM

William Reynish (billreynish) awarded a token.Nov 27 2019, 2:54 AM

This generally works fairly well now.

A few notes:

The new gizmos are HUGE, often pointing out of the viewport. They are at least twice as large as the current transform gizmos, which is excessive.

Probably we should not show these types of gizmos while dragging, as they will flip and move around erratically (see Randomize tool for eg)

I think we should change the default drag option so that it's set to Select. IMO it's just a more useful and expected default behaviour.

A smaller UI layout thing: It's somewhat unfortunate that the menu titles are so far removed from the menus in the top bar. It's more a general issue, but it shows up here:

Would be nicer like this:

Although really it's a separate issue to be solved in a different patch - just noting it here because it makes this UI look harder to read than necessary.

Replying inline, mostly agree with suggestions however I'd like to see this get users testing before spending more time on it.

In D6301#146814, @William Reynish (billreynish) wrote:

This generally works fairly well now.

A few notes:

The new gizmos are HUGE, often pointing out of the viewport. They are at least twice as large as the current transform gizmos, which is excessive.

Updated, use smaller tool handle gizmo roughly matching size of transform gizmo outer handles.

Probably we should not show these types of gizmos while dragging, as they will flip and move around erratically (see Randomize tool for eg)

Agree.

I think we should change the default drag option so that it's set to Select. IMO it's just a more useful and expected default behaviour.

This is a bigger change, rather handle it separately.

A smaller UI layout thing: It's somewhat unfortunate that the menu titles are so far removed from the menus in the top bar. It's more a general issue, but it shows up here:

Would be nicer like this:

Although really it's a separate issue to be solved in a different patch - just noting it here because it makes this UI look harder to read than necessary.

Agree, layout stuff we should improve generally, I think it's not interfering with testing this patch.

Harbormaster completed remote builds in B5787: Diff 19855.Nov 27 2019, 6:44 AM

@Campbell Barton (campbellbarton) Noticed perhaps the biggest issue with this: it doesn’t apply to the transform tools. This is the most useful case for this I think, so it should also apply to move, rotate & scale.