Fix T71860: No versioning for drivers in Mapping node.
ClosedPublic
Actions

Authored by Omar Emara (OmarSquircleArt) on Nov 25 2019, 10:44 AM.

Details

Reviewers

Brecht Van Lommel (brecht)
Sergey Sharybin (sergey)
Bastien Montagne (mont29)

Commits

rB14da2b18fce3: Fix T71860: No versioning for drivers in Mapping node.

Summary

The new Mapping node was missing versioning code for drivers.
This patch refactors existing code and add versioning for drivers.

Diff Detail

Repository: rB Blender

Event Timeline

Omar Emara (OmarSquircleArt) created this revision.Nov 25 2019, 10:44 AM

Harbormaster completed remote builds in B5767: Diff 19815.Nov 25 2019, 10:44 AM

File for testing drivers:

mapping_node_driver_versioning.blend622 KBDownload

File for testing animations, includes four node trees:

mapping_node_animation_versioning.blend684 KBDownload

Omar Emara (OmarSquircleArt) mentioned this in T71860: Mapping Node Issue. Translation and reading of mapping node data is broken between 2.80 - 2.81.Nov 25 2019, 10:47 AM

Bartosz Moniewski (monio) awarded a token.Nov 25 2019, 12:56 PM

Sergey Sharybin (sergey) added inline comments.Nov 25 2019, 5:00 PM

source/blender/blenloader/intern/versioning_cycles.c
934–935	Wouldn't it be more reliable and less verbose to use `BKE_fcurves_id_cb`?

Utilize the BKE_fcurves_id_cb function.

Harbormaster completed remote builds in B5770: Diff 19824.Nov 25 2019, 5:48 PM

Omar Emara (OmarSquircleArt) marked an inline comment as done.Nov 25 2019, 5:48 PM

Looks good to me.

@Campbell Barton (campbellbarton) , @Bastien Montagne (mont29) want to have an extra eye?

This revision is now accepted and ready to land.Nov 25 2019, 6:00 PM

LGTM as well.

Closed by commit rB14da2b18fce3: Fix T71860: No versioning for drivers in Mapping node. (authored by Omar Emara (OmarSquircleArt)). · Explain WhyNov 26 2019, 12:47 PM

This revision was automatically updated to reflect the committed changes.

Omar Emara (OmarSquircleArt) added a commit: rB14da2b18fce3: Fix T71860: No versioning for drivers in Mapping node..

Revision Contents
Changeset List

Path

Size

source/

blender/

blenloader/

intern/

versioning_cycles.c

95 lines

Diff 19831

View Options

source/blender/blenloader/intern/versioning_cycles.c

Fix T71860: No versioning for drivers in Mapping node.ClosedPublicActions