Page MenuHome
Differential D6309

FIX T68677 - Graph editor zoom to selected ignores scrollbar occlusion
ClosedPublic
Actions

Authored by Aurel W (aurel) on Nov 26 2019, 2:48 PM.

Details

Reviewers
Sybren A. Stüvel (sybren)
Julian Eisel (Severin)
Maniphest Tasks
T68677: Graph editor zoom to selected ignores scrollbar occlusion
Commits
rB1ee253c014c3: Fix T68677: Graph Editor zoom to selected ignores scrollbar occlusion
Summary

Just a little annoyance, but the zoom to selected simply doesn't work with the new scrollbar. Just adding this extra padding seems to work nice. Also implemented a more complex padding behavior, but after testing I found it just unnecessary and I reverted my patch to this simple solution.

Diff Detail

Event Timeline

Aurel W (aurel) created this revision.Nov 26 2019, 2:48 PM
Aurel W (aurel) added a comment.Nov 26 2019, 2:52 PM

Well, scrollber -> scrollbar

Philipp Oeser (lichtwerk) added reviewers: Sybren A. Stüvel (sybren), Julian Eisel (Severin).Nov 26 2019, 2:56 PM
Philipp Oeser (lichtwerk) added a subscriber: Philipp Oeser (lichtwerk).

Nice, I remember talking about this before...

Ray Molenkamp (LazyDodo) added a task: T68677: Graph editor zoom to selected ignores scrollbar occlusion.Jan 20 2020, 12:03 AM
William Reynish (billreynish) awarded a token.Jan 20 2020, 1:28 AM
Sybren A. Stüvel (sybren) accepted this revision.Jan 20 2020, 11:13 AM
Sybren A. Stüvel (sybren) added 1 blocking reviewer(s): Julian Eisel (Severin).

LGTM apart from the note.

source/blender/editors/space_graph/graph_edit.c
298–303

Initialising to 0 doesn't make much sense to me here. Why not default to V2D_SCROLL_HANDLE_HEIGHT instead?

Julian Eisel (Severin) accepted this revision.EditedJan 21 2020, 2:21 PM

Fix seems fine, thanks! I'll push a slightly different version which does the same in effect.

This revision is now accepted and ready to land.Jan 21 2020, 2:21 PM
Closed by commit rB1ee253c014c3: Fix T68677: Graph Editor zoom to selected ignores scrollbar occlusion (authored by Aurel W (aurel), committed by Julian Eisel (Severin)). · Explain WhyJan 21 2020, 4:38 PM
This revision was automatically updated to reflect the committed changes.
Julian Eisel (Severin) added a commit: rB1ee253c014c3: Fix T68677: Graph Editor zoom to selected ignores scrollbar occlusion.

Revision Contents
Changeset List

PathSize
source/
blender/
editors/
space_graph/
6 lines

Diff 19834

View Options

source/blender/editors/space_graph/graph_edit.c

Loading...