Page MenuHome
Differential D6311

Fix T71795: Unproject with high clipping range sometimes results in nans
ClosedPublic
Actions

Authored by Germano Cavalcante (mano-wii) on Nov 26 2019, 9:45 PM.

Details

Reviewers
Campbell Barton (campbellbarton)
Clément Foucault (fclem)
Maniphest Tasks
T71795: Too high clipping range + Auto Depth may send view location to oblivion
Commits
rB26e4f4a8c475: Fix T71795: Unproject with high clipping range sometimes results in nans
Summary

In some cases you cannot get the original value of clip_end through the projection matrix.
It might be a good idea to figure out the maximum limit for these float operations and update mat4_frustum_set to not fall in such cases.
But this patch only intended to prevent unproject operations from operating with infs and nans.

Ref T71795

Diff Detail

Repository
rB Blender
Branch
master
Build Status
Buildable 5784
Build 5784: arc lint + arc unit

Event Timeline

Germano Cavalcante (mano-wii) created this revision.Nov 26 2019, 9:45 PM
Harbormaster completed remote builds in B5784: Diff 19849.Nov 26 2019, 9:45 PM
This revision was not accepted when it landed; it landed in state Needs Review.Dec 19 2019, 3:45 PM
Closed by commit rB26e4f4a8c475: Fix T71795: Unproject with high clipping range sometimes results in nans (authored by Germano Cavalcante (mano-wii)). · Explain Why
This revision was automatically updated to reflect the committed changes.
Germano Cavalcante (mano-wii) added a commit: rB26e4f4a8c475: Fix T71795: Unproject with high clipping range sometimes results in nans.

Revision Contents
Changeset List

PathSize
source/
blender/
gpu/
intern/
3 lines

Diff 19849

View Options

source/blender/gpu/intern/gpu_matrix.c

Loading...