This diff doesn't revert rB450685b15664 actually
And there may be issue, that 50% proxy of clip that is 1000 x 1000 will be 500 x 500 regardless of what your project resolution is set to.

Eitan Traurig (EitanSomething) edited the summary of this revision. (Show Details)Nov 28 2019, 2:46 AM

In D6314#147251, @Richard Antalik (ISS) wrote:

I guess something like this could work, will have look into this in debug.

This diff doesn't revert rB450685b15664 actually
And there may be issue, that 50% proxy of clip that is 1000 x 1000 will be 500 x 500 regardless of what your project resolution is set to.

I haven’t tested it but
The clip should scale to fit when the offset button is turned off,but when it I selected it will stay at 500 x 500

Eitan Traurig (EitanSomething) edited the summary of this revision. (Show Details)Nov 28 2019, 3:33 AM

Fix Cropping

Harbormaster completed remote builds in B5824: Diff 19919.Nov 28 2019, 4:51 AM

Eitan Traurig (EitanSomething) edited the summary of this revision. (Show Details)Nov 28 2019, 4:54 AM

Eitan Traurig (EitanSomething) retitled this revision from Fix T51828 to Fix T51828 VSE Proxy smaller than 100% produces wrong results when using Crop or Offset for movie strip.Dec 13 2019, 3:06 AM

Update changes

Harbormaster completed remote builds in B6137: Diff 20560.Dec 30 2019, 11:15 PM

Eitan Traurig (EitanSomething) edited the summary of this revision. (Show Details)Dec 31 2019, 6:29 AM

Eitan Traurig (EitanSomething) edited the summary of this revision. (Show Details)Jan 1 2020, 5:14 AM

Richard Antalik (ISS) requested changes to this revision.Jan 5 2020, 10:34 PM

Richard Antalik (ISS) added inline comments.

source/blender/blenkernel/intern/sequencer.c
1843–1850	I would be much happier, if we could use `get_proxy_filename()` from `indexer.c` in this case we are creating new code to "emulate" it's function. Not good practice. Also there was this switch when you use proxy per project or per strip What I want to say in general is that we could refactor this code to make it a bit more human readable. I haven't seen this code for a while, and I barely know what I am looking at.
1939	This line will have impact on performance - it will have to decode (most likely) several frames. I guess this function could be quite streamlined.
3857	I guess, that you have re-used this function to determine, if the proxy file exists. In that case, you should rename it.

This revision now requires changes to proceed.Jan 5 2020, 10:34 PM

Eitan Traurig (EitanSomething) added inline comments.Jan 8 2020, 10:41 PM

source/blender/blenkernel/intern/sequencer.c
1843–1850	we should use this code and then refactor the get proxy system in another patch.
3857	I think we can replace seq_proxy_fetch in this case with seq_proxy_get_fname and BLI_exist

Rename variables

Harbormaster completed remote builds in B6203: Diff 20699.Jan 9 2020, 12:57 AM

ageha (ageha) added a subscriber: ageha (ageha).Jan 11 2020, 1:37 PM

Eitan Traurig (EitanSomething) mentioned this in D6786: VSE: Refactor proxy loading.Feb 9 2020, 10:49 PM

Fix T51828 VSE Proxy smaller than 100% produces wrong results when using Crop or Offset for movie strip
Needs ReviewPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 19862

source/blender/blenkernel/intern/sequencer.c

Fix T51828 VSE Proxy smaller than 100% produces wrong results when using Crop or Offset for movie stripNeeds ReviewPublicActions