Page MenuHome
Differential D6324

Sculpt: Sculpt plane cursor preview
Needs RevisionPublic
Actions

Authored by Pablo Dobarro (pablodp606) on Nov 28 2019, 1:36 PM.
Tags
Subscribers
233 (233)
Hadrien Brissaud (hadrien)
Jan Kadeřábek (jendabek)
Julien Kaspar (JulienKaspar)
Paul (rice)
Tokens
"100" token, awarded by amalbubble."Love" token, awarded by Mike.Bailey."Love" token, awarded by threedslider."Like" token, awarded by MetinSeven."Love" token, awarded by TheAngerSpecialist."Like" token, awarded by erickblender."Love" token, awarded by Brandon777."100" token, awarded by Frozen_Death_Knight."Love" token, awarded by JulienKaspar.

Details

Reviewers
Jeroen Bakker (jbakker)
Summary

This adds a sculpt plane preview to the cursor during a stroke to help
visualizing the sculpt plane options. This can be enabled/disabled per
brush.

Requested by @Julien Kaspar (JulienKaspar)

Diff Detail

Repository
rB Blender
Branch
sculpt-planes-preview (branched from master)
Build Status
Buildable 5828
Build 5828: arc lint + arc unit

Event Timeline

Pablo Dobarro (pablodp606) created this revision.Nov 28 2019, 1:36 PM
Harbormaster completed remote builds in B5828: Diff 19927.Nov 28 2019, 1:36 PM
Pablo Dobarro (pablodp606) edited the summary of this revision. (Show Details)Nov 28 2019, 1:38 PM
Pablo Dobarro (pablodp606) added a reviewer: Jeroen Bakker (jbakker).
Pablo Dobarro (pablodp606) added a project: BF Blender (2.82).
Pablo Dobarro (pablodp606) added a subscriber: Julien Kaspar (JulienKaspar).
Julien Kaspar (JulienKaspar) awarded a token.Nov 28 2019, 2:02 PM
Paul (rice) added a subscriber: Paul (rice).Nov 28 2019, 2:27 PM

Personally i would drop Orginal Plane opion where cursor indicator is stationary and does not follow tablet pointer.

Ps. Please bring back resizing/strength widget from 2.79/2.8. Thanks.

Kenn Nyström (Frozen_Death_Knight) awarded a token.Nov 28 2019, 3:02 PM
Brandon (Brandon777) awarded a token.Nov 28 2019, 10:34 PM
Hadrien Brissaud (hadrien) added a subscriber: Hadrien Brissaud (hadrien).Nov 30 2019, 8:22 PM

Maybe this should be a global property ? I'm not sure how much added value there is in having it per-brush. In any case, great qol addition.

Erick Tukuniata (erickblender) awarded a token.Nov 30 2019, 8:45 PM
Joseph Brandenburg (TheAngerSpecialist) awarded a token.Dec 2 2019, 5:47 PM
Metin Seven (MetinSeven) awarded a token.Dec 11 2019, 2:35 PM
Laurent Le Flem (threedslider) awarded a token.Dec 11 2019, 6:37 PM
Jeroen Bakker (jbakker) added a comment.Dec 12 2019, 11:38 AM

Code wise I don't see a problem. But looking at the posts from other people we would like to start with a short design first and link that design task in this patch.
Focus on explaining why we need it and why this solution fits the needs.

Jeroen Bakker (jbakker) requested changes to this revision.Dec 12 2019, 11:52 AM
This revision now requires changes to proceed.Dec 12 2019, 11:52 AM
Michael Bailey (Mike.Bailey) awarded a token.Jul 21 2021, 9:07 PM
Amal Kumar (amalbubble) awarded a token.Jul 22 2021, 6:40 PM
233 (233) added a subscriber: 233 (233).Sep 12 2021, 10:11 AM
Aleshkina Anna (world_is_peace) added a subscriber: Aleshkina Anna (world_is_peace).Mar 4 2022, 12:32 AM
Aleshkina Anna (world_is_peace) removed a subscriber: Aleshkina Anna (world_is_peace).
Julien Kaspar (JulienKaspar) mentioned this in T98291: Unfinished Revisions.May 20 2022, 6:47 PM
Jan Kadeřábek (jendabek) added a subscriber: Jan Kadeřábek (jendabek).Jun 23 2022, 3:08 PM

Revision Contents
Changeset List

PathSize
release/
scripts/
startup/
bl_ui/
1 line
source/
blender/
editors/
sculpt_paint/
75 lines
5 lines
3 lines
makesdna/
1 line
makesrna/
intern/
9 lines

Diff 19927

View Options

release/scripts/startup/bl_ui/space_view3d_toolbar.py

Loading...
View Options

source/blender/editors/sculpt_paint/paint_cursor.c

Loading...
View Options

source/blender/editors/sculpt_paint/sculpt.c

Loading...
View Options

source/blender/editors/sculpt_paint/sculpt_intern.h

Loading...
View Options

source/blender/makesdna/DNA_brush_types.h

Loading...
View Options

source/blender/makesrna/intern/rna_brush.c

Loading...