Current code in edbm_offset_edgeloop_exec doesn't actually set the scenes toolsettings selecmode, only the editmesh's selectmode. Think we can safely just use EDBM_selectmode_disable_multi and always turn off face mode when this tool is used, much like loopcut. Also made EDBM_selectmode_disable_multi_ex only return true if mode was changed.
Details
Details
- Reviewers
Campbell Barton (campbellbarton) - Maniphest Tasks
- T71882: Offset Edge Slide doesn't switch selection mode correctly
Diff Detail
Diff Detail
- Repository
- rB Blender
Event Timeline
Comment Actions
I can confirm that this fixes the issue mentioned in the bug report, but I do not know the implications of this change.
Comment Actions
Hi, I'd like to request that this be reviewed, weather it is accepted or abandoned. It has been 3 months with no other response. I also have another patch that fixes an unreported bug that is related to selectmode consistency between toolsettings and editmesh/bmesh in loop cut but this is blocking.
I think this is still the correct way to handle the issue. The code that is being removed here is from @Dalai Felinto (dfelinto) in revision rBf6b902a9caf3aa05185ea0d0cc4163355629aa39. This was before the EDBM_selectmode_disable_multi was added. Now that it is here it basically does the same thing as the removed code, loops over the edit objects and sets the selectmode in the editmesh and bmesh.
Comment Actions
Committed rBeaa21df5051c: Fix T71882: Offset Edge Slide doesn't switch selection mode, based on this patch with some modifications not to switch modes if no offset is performed.