Page MenuHome
Differential D6351

Fix T71576 Mesh error on mutimaterial Meshes on legacy nvidia drivers
ClosedPublic
Actions

Authored by Clément Foucault (fclem) on Dec 3 2019, 2:51 PM.

Details

Reviewers
Jeroen Bakker (jbakker)
Commits
rBcf77b67c459d: Fix T71576 Mesh error on mutimaterial Meshes on legacy nvidia drivers

Diff Detail

Repository
rB Blender

Event Timeline

Clément Foucault (fclem) created this revision.Dec 3 2019, 2:51 PM
Harbormaster completed remote builds in B5891: Diff 20042.Dec 3 2019, 2:51 PM
Clément Foucault (fclem) mentioned this in T71576: Viewport/crash artefacts with multiple materials and legacy NVIDIA drivers.Dec 3 2019, 3:00 PM
Jeroen Bakker (jbakker) added a comment.Dec 3 2019, 3:01 PM

Personally I find the !defined confusing to read. but cannot find a good solution.
what about adding !OS_MAC to the first if.

This separates the technical limitations from the functional needs.

Clément Foucault (fclem) added a comment.Dec 3 2019, 3:03 PM
In D6351#148204, @Jeroen Bakker (jbakker) wrote:

Personally I find the !defined confusing to read. but cannot find a good solution.
what about adding !OS_MAC to the first if.

This separates the technical limitations from the functional needs.

I remembered some compiler not parsing multi-line macros correctly. Maybe it's not the case anymore.

Jeroen Bakker (jbakker) added a comment.Dec 3 2019, 3:04 PM

better be safe than sorry. will accept the patch.

Jeroen Bakker (jbakker) accepted this revision.Dec 3 2019, 3:05 PM
This revision is now accepted and ready to land.Dec 3 2019, 3:05 PM
Closed by commit rBcf77b67c459d: Fix T71576 Mesh error on mutimaterial Meshes on legacy nvidia drivers (authored by Clément Foucault (fclem)). · Explain WhyDec 5 2019, 11:29 AM
This revision was automatically updated to reflect the committed changes.
Clément Foucault (fclem) added a commit: rBcf77b67c459d: Fix T71576 Mesh error on mutimaterial Meshes on legacy nvidia drivers.
Clément Foucault (fclem) added a reverting change: rBe2806b7429c7: Revert "Fix T71576 Mesh error on mutimaterial Meshes on legacy nvidia drivers".Dec 5 2019, 11:31 AM

Revision Contents
Changeset List

PathSize
source/
blender/
draw/
intern/
shaders/
9 lines
gpu/
1 line
intern/
15 lines
5 lines

Diff 20092

View Options

source/blender/draw/intern/shaders/common_view_lib.glsl

Loading...
View Options

source/blender/gpu/GPU_extensions.h

Loading...
View Options

source/blender/gpu/intern/gpu_extensions.c

Loading...
View Options

source/blender/gpu/intern/gpu_shader.c

Loading...