Page MenuHome
Differential D6353

Complex vector operators
AbandonedPublic
Actions

Authored by james egien (cubic_sloth) on Dec 3 2019, 10:27 PM.

Details

Reviewers
Omar Emara (OmarSquircleArt)
Brecht Van Lommel (brecht)
Group Reviewers
Cycles
Summary

complex operators added to the vector math node

complex multiplication

complex division

complex power

complex log

Diff Detail

Repository
rB Blender

Event Timeline

james egien (cubic_sloth) created this revision.Dec 3 2019, 10:27 PM
Brecht Van Lommel (brecht) added a comment.Dec 4 2019, 1:08 AM

For the same reasons as D6336, I don't think this should be builtin functionality, so I'm afraid I'll have to reject this.

Assuming a vector (a, b, c) is a complex number a + bi is not very clear and does belong in a Vector Math node, which should be just about 3D vectors.

But in general, I think complex number are just a bit too obscure to have as core functionality in shading nodes.

Brecht Van Lommel (brecht) abandoned this revision.Feb 14 2020, 6:35 PM

Thanks for the patch, but closing this revision since this not functionality I think we should have in core Cycles.

Revision Contents
Changeset List

PathSize
intern/
cycles/
kernel/
shaders/
38 lines
svm/
10 lines
17 lines
5 lines
render/
1 line
11 lines
source/
blender/
gpu/
shaders/
material/
77 lines
makesdna/
5 lines
makesrna/
intern/
4 lines
nodes/
shader/
nodes/
10 lines

Diff 20054

View Options

intern/cycles/kernel/shaders/node_vector_math.osl

Loading...
View Options

intern/cycles/kernel/svm/svm_math.h

Loading...
View Options

intern/cycles/kernel/svm/svm_math_util.h

Loading...
View Options

intern/cycles/kernel/svm/svm_types.h

Loading...
View Options

intern/cycles/render/nodes.h

Loading...
View Options

intern/cycles/render/nodes.cpp

Loading...
View Options

source/blender/gpu/shaders/material/gpu_shader_material_vector_math.glsl

Loading...
View Options

source/blender/makesdna/DNA_node_types.h

Loading...
View Options

source/blender/makesrna/intern/rna_nodetree.c

Loading...
View Options

source/blender/nodes/shader/nodes/node_shader_vector_math.c

Loading...