Page MenuHome
Differential D6356

Overlay: Hide Bone Relationship Lines
ClosedPublic
Actions

Authored by Jeroen Bakker (jbakker) on Dec 4 2019, 8:32 AM.

Details

Reviewers
Clément Foucault (fclem)
Maniphest Tasks
T72157: Relationship lines not displaying correctly (Armature Edit/Pose Modes)
Commits
rB824c2659382b: Fix T72157: Overlay Hide Bone Relationship Lines
Summary

Bone relationship lines needs to be hidden in:

  • object mode
  • or when relationship lines are turned off

Diff Detail

Repository
rB Blender

Event Timeline

Jeroen Bakker (jbakker) created this revision.Dec 4 2019, 8:32 AM
Harbormaster completed remote builds in B5897: Diff 20058.Dec 4 2019, 8:32 AM
Jeroen Bakker (jbakker) added a reviewer: Clément Foucault (fclem).Dec 4 2019, 8:33 AM
Jeroen Bakker (jbakker) updated this revision to Diff 20059.Dec 4 2019, 8:50 AM

Use the do_relations attribute

Harbormaster completed remote builds in B5898: Diff 20059.Dec 4 2019, 8:50 AM
Jeroen Bakker (jbakker) added a comment.Dec 4 2019, 8:50 AM

@Clément Foucault (fclem) During this fix it came to my attention that ArmatureDrawContext.do_relations is never set and unclear what the difference is between show_relations and do_relations. I assume that the do_relations was meant for the mode it is in

Clément Foucault (fclem) accepted this revision.Dec 4 2019, 12:52 PM
This revision is now accepted and ready to land.Dec 4 2019, 12:52 PM
Closed by commit rB824c2659382b: Fix T72157: Overlay Hide Bone Relationship Lines (authored by Jeroen Bakker (jbakker)). · Explain WhyDec 4 2019, 3:19 PM
This revision was automatically updated to reflect the committed changes.
Jeroen Bakker (jbakker) added a commit: rB824c2659382b: Fix T72157: Overlay Hide Bone Relationship Lines.

Revision Contents
Changeset List

PathSize
source/
blender/
draw/
engines/
overlay/
13 lines

Diff 20070

View Options

source/blender/draw/engines/overlay/overlay_armature.c

Loading...