Page MenuHome
Differential D6358

Fix T72148: OBJ import could fail with spaces in filenames
ClosedPublic
Actions

Authored by Philipp Oeser (lichtwerk) on Dec 4 2019, 1:54 PM.

Details

Reviewers
Bastien Montagne (mont29)
Maniphest Tasks
T72148: Error importing .obj from Photoshop (filename with space)
Commits
rBAbf89c1eb2800: Fix T72148: OBJ import could fail with spaces in filenames
Summary

Thing here was that files could actually be loaded ('obj_image_load' has
smart code for this), but tokenizing the corresponding line afterwards
couls still fail [would have part of a filename still in image_data
list].

Now also correct this 'image_data' list in case 'obj_image_load' found
images with filename spaces.

Diff Detail

Repository
rBA Blender Add-ons
Branch
T72148 (branched from master)
Build Status
Buildable 5901
Build 5901: arc lint + arc unit

Event Timeline

Philipp Oeser (lichtwerk) created this revision.Dec 4 2019, 1:54 PM
Harbormaster completed remote builds in B5901: Diff 20064.Dec 4 2019, 1:54 PM
KiJeon (0o00o0oo) awarded a token.Dec 4 2019, 6:30 PM
KiJeon (0o00o0oo) added a subscriber: KiJeon (0o00o0oo).
Bastien Montagne (mont29) accepted this revision.Dec 13 2019, 4:34 PM

LGTM, thanks. :)

This revision is now accepted and ready to land.Dec 13 2019, 4:34 PM
Closed by commit rBAbf89c1eb2800: Fix T72148: OBJ import could fail with spaces in filenames (authored by Philipp Oeser (lichtwerk)). · Explain WhyDec 16 2019, 12:53 PM
This revision was automatically updated to reflect the committed changes.
Philipp Oeser (lichtwerk) added a commit: rBAbf89c1eb2800: Fix T72148: OBJ import could fail with spaces in filenames.

Revision Contents
Changeset List

PathSize
io_scene_obj/
15 lines

Diff 20064

View Options

io_scene_obj/import_obj.py

Loading...