DrawManager: Update Auto Layer Names
AbandonedPublic
Actions

Authored by Jeroen Bakker (jbakker) on Dec 4 2019, 2:45 PM.

Details

Reviewers

Clément Foucault (fclem)

Maniphest Tasks

T72161: Material Attribute Node in Linear Space

Summary

When a user switches from workbench to eevee and the material uses the
same CD's as workbench the materials weren't updated making the
viewport rendering incorrect.

Diff Detail

Repository

rB Blender

Branch

T72161 (branched from master)

Build Status

Buildable 5902
Build 5902: arc lint + arc unit

Event Timeline

Jeroen Bakker (jbakker) created this revision.Dec 4 2019, 2:45 PM

Harbormaster completed remote builds in B5902: Diff 20066.Dec 4 2019, 2:45 PM

Jeroen Bakker (jbakker) added a reviewer: Clément Foucault (fclem).Dec 4 2019, 2:46 PM

Another solution would be use a different set of auto_layer_* fields for the surface batch. Surface batches only have a single active layer. But that needs a lot of refactoring.

Jeroen Bakker (jbakker) requested review of this revision.Dec 11 2019, 8:35 AM

Clément Foucault (fclem) requested changes to this revision.Jan 15 2020, 10:50 PM

Clément Foucault (fclem) added inline comments.

source/blender/draw/intern/draw_cache_impl_mesh.c
790	What I would prefer, store the cd mask the layer names were generated against. Just reset the mask to 0 if the names are discarded. Much more descriptive and less error prone.

This revision now requires changes to proceed.Jan 15 2020, 10:50 PM

An alternative solution was implemented which removes the need of the srgb uniforms 6eaf51ef3e5b.

Revision Contents
Changeset List

Path

Size

source/

blender/

draw/

intern/

draw_cache_extract.h

1 line

draw_cache_impl_mesh.c

8 lines

Diff 20066

View Options

source/blender/draw/intern/draw_cache_extract.h