Tracking: Selection Crash
ClosedPublic
Actions

Authored by Jeroen Bakker (jbakker) on Dec 4 2019, 3:48 PM.

Details

Reviewers

Sebastian Koenig (sebastian_k)
Sergey Sharybin (sergey)

Maniphest Tasks

T72162: Crash when selecting camera maker in 3D-View when different camera is active

Commits

rB79476a9c0ab9: Tracking: Selection Crash

Summary

Blender crashes when selecting a marker in the 3d viewport that is from the non active scene camera. This patch will solve this crash, but introduced a new scenario that isn't thought out. In the new scenario it is still hard to select a marker via the 3d viewport.

I would expect that when selecting a marker in this case would select the camera where the marker belongs to and select the marker that is under the mouse button. But this is an assumption and would like the tracking module to see what actually needs to happen.

Diff Detail

Repository: rB Blender

Event Timeline

Jeroen Bakker (jbakker) created this revision.Dec 4 2019, 3:48 PM

Harbormaster completed remote builds in B5903: Diff 20072.Dec 4 2019, 3:48 PM

Jeroen Bakker (jbakker) added a reviewer: Sergey Sharybin (sergey).Dec 4 2019, 3:49 PM

Jeroen Bakker (jbakker) added a project: Motion Tracking.

Jeroen Bakker (jbakker) added inline comments.Dec 4 2019, 3:54 PM

source/blender/editors/space_view3d/view3d_select.c
2080–2081	false, or true doesn't matter for the question, but this should be put back to false if we continue

In my previous diff I unintentionally changed the false parameter to true. This diff changes it back to the original setting.

Harbormaster completed remote builds in B5904: Diff 20073.Dec 4 2019, 3:54 PM

The viewport and the movie clip editor should display the selection of the markers in the same way. Fixing the crash shows that the selection drawing isn't handled the same.

Jeroen Bakker (jbakker) retitled this revision from Tracking: Selection Crash to [WIP] Tracking: Selection Crash.Dec 5 2019, 3:52 PM

Jeroen Bakker (jbakker) edited the summary of this revision. (Show Details)

Jeroen Bakker (jbakker) removed a reviewer: Sergey Sharybin (sergey).

Jeroen Bakker (jbakker) retitled this revision from [WIP] Tracking: Selection Crash to Tracking: Selection Crash.Dec 10 2019, 11:10 AM

Jeroen Bakker (jbakker) edited the summary of this revision. (Show Details)

Jeroen Bakker (jbakker) added reviewers: Sebastian Koenig (sebastian_k), Sergey Sharybin (sergey).

Jeroen Bakker (jbakker) requested review of this revision.Dec 29 2019, 11:13 PM

I would expect that when selecting a marker in this case would select the camera where the marker belongs to and select the marker that is under the mouse button. But this is an assumption and would like the tracking module to see what actually needs to happen.

That sounds a correct behavior.

From reading the code the patch seems good to me.

This revision is now accepted and ready to land.Dec 30 2019, 9:16 AM

Closed by commit rB79476a9c0ab9: Tracking: Selection Crash (authored by Jeroen Bakker (jbakker)). · Explain WhyDec 30 2019, 9:26 AM

This revision was automatically updated to reflect the committed changes.

Jeroen Bakker (jbakker) added a commit: rB79476a9c0ab9: Tracking: Selection Crash.