Page MenuHome
Differential D6361

Fix T72121: Measurements are being drawn incorrectly if one end is off screen
ClosedPublic
Actions

Authored by Germano Cavalcante (mano-wii) on Dec 4 2019, 5:35 PM.

Details

Reviewers
Campbell Barton (campbellbarton)
Clément Foucault (fclem)
Maniphest Tasks
T72121: Measurements are being drawn incorrectly if one end is off screen
Commits
rB4a9a8611f2bb: Fix T72121: Measurements are being drawn incorrectly if one end is off screen
Summary

The solution is to distribute the drawing for part to be done in 3d
(dashed lines, arc) and another part in 2d (text and caps).

Ref T72121

Diff Detail

Repository
rB Blender

Event Timeline

Germano Cavalcante (mano-wii) created this revision.Dec 4 2019, 5:35 PM
Harbormaster completed remote builds in B5906: Diff 20076.Dec 4 2019, 5:35 PM
Germano Cavalcante (mano-wii) edited the summary of this revision. (Show Details)Dec 4 2019, 8:05 PM
Germano Cavalcante (mano-wii) added a task: T72121: Measurements are being drawn incorrectly if one end is off screen.
Clément Foucault (fclem) requested changes to this revision.Mar 23 2020, 7:39 PM

Way over complicated. Just find the intersection with camera near plane and clip if needed.
Only render extremities and dimensions if they are on screen and in front of near plane too.

Note this is only necessary in perspective.

This revision now requires changes to proceed.Mar 23 2020, 7:39 PM
Clément Foucault (fclem) updated this revision to Diff 25082.May 25 2020, 7:12 PM
  • Only draw segment ends if on screen
  • Merge branch 'blender-v2.83-release' into arcpatch-D6361
Harbormaster completed remote builds in B8202: Diff 25082.May 25 2020, 7:12 PM
Clément Foucault (fclem) updated this revision to Diff 25083.May 25 2020, 7:16 PM
  • Fix comment
Harbormaster completed remote builds in B8203: Diff 25083.May 25 2020, 7:16 PM
Clément Foucault (fclem) accepted this revision.May 25 2020, 7:16 PM
This revision is now accepted and ready to land.May 25 2020, 7:16 PM
Closed by commit rB4a9a8611f2bb: Fix T72121: Measurements are being drawn incorrectly if one end is off screen (authored by Clément Foucault (fclem)). · Explain WhyMay 25 2020, 7:18 PM
This revision was automatically updated to reflect the committed changes.
Clément Foucault (fclem) added a commit: rB4a9a8611f2bb: Fix T72121: Measurements are being drawn incorrectly if one end is off screen.

Revision Contents
Changeset List

PathSize
source/
blender/
editors/
space_view3d/
185 lines

Diff 25084

View Options

source/blender/editors/space_view3d/view3d_gizmo_ruler.c

Loading...