Page MenuHome
Differential D638

Fixed T40930
ClosedPublic
Actions

Authored by Bastien Montagne (mont29) on Jul 10 2014, 3:48 AM.

Details

Reviewers
x (robschia)
Maniphest Tasks
T40930: Select Similar (Smooth Faces)
Commits
rBSc79c48cc93b5: Fix T40930: Add a new option to select faces by smooth/flat shading.
rBc79c48cc93b5: Fix T40930: Add a new option to select faces by smooth/flat shading.
Summary

Added a new option to select faces with the same shading.

Fixed this: https://developer.blender.org/T40930

Diff Detail

Repository
rB Blender

Event Timeline

Campbell Barton (campbellbarton) added inline comments.Jul 12 2014, 3:54 PM
source/blender/bmesh/operators/bmo_similar.c
250

in this case shading is either on/off, using the delta is meaningless. just check they are equal.

source/blender/editors/mesh/editmesh_select.c
712

Shading is too generic a term, would use SMOOTH

x (robschia) updated this revision to Unknown Object (????).Jul 12 2014, 6:54 PM

delta not used anymore in the code, "shading" term changed to "smooth"

Bastien Montagne (mont29) requested changes to this revision.Aug 18 2014, 4:08 PM
Bastien Montagne (mont29) added a reviewer: Bastien Montagne (mont29).
Bastien Montagne (mont29) added a subscriber: Bastien Montagne (mont29).
Bastien Montagne (mont29) added inline comments.
source/blender/bmesh/operators/bmo_similar.c
250–251

You should use fs and fm (defined resp. as f_ext|i].f and f_ext[indices[idx]].f).

Also, better to use BM_elem_flag_… familly of funcs to handle flags, see start of intern/bmesh_inline.h file.

This revision now requires changes to proceed.Aug 18 2014, 4:08 PM
Bastien Montagne (mont29) commandeered this revision.Dec 28 2014, 6:54 PM
Bastien Montagne (mont29) edited reviewers, added: x (robschia); removed: Bastien Montagne (mont29).

No sense to wait months for such a simple thing, will update patch and commit.

Bastien Montagne (mont29) updated this revision to Diff 3057.Dec 28 2014, 7:07 PM
  • Cleanup...
Closed by commit rBc79c48cc93b5: Fix T40930: Add a new option to select faces by smooth/flat shading. (authored by Bastien Montagne (mont29)). · Explain WhyDec 28 2014, 7:13 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
source/
blender/
bmesh/
intern/
1 line
operators/
7 lines
editors/
mesh/
3 lines

Diff 3058

View Options

source/blender/bmesh/intern/bmesh_operators.h

Loading...
View Options

source/blender/bmesh/operators/bmo_similar.c

Loading...
View Options

source/blender/editors/mesh/editmesh_select.c

Loading...