Page MenuHome
Differential D6393

Fix T72124: LookDev Sphere Rendering
ClosedPublic
Actions

Authored by Jeroen Bakker (jbakker) on Dec 11 2019, 1:39 PM.

Details

Reviewers
Clément Foucault (fclem)
Maniphest Tasks
T72124: Lookdev Spheres render black on latest master with Overlay refactor commit
Commits
rBb30a722f2d6f: Fix T72124: LookDev Sphere Rendering
Summary

Due to the refactoring of the overlay engine the draw caches were
changed. The sphere batch used to have positions and normals. After the
refactoring it didn't had the normals anymore. The normals are needed
for shading. As they were not there the look dev spheres were rendered
black.

This change add the nor attribute to DRW_cache_sphere_get batch.

Diff Detail

Repository
rB Blender

Event Timeline

Jeroen Bakker (jbakker) created this revision.Dec 11 2019, 1:39 PM
Harbormaster completed remote builds in B5968: Diff 20209.Dec 11 2019, 1:39 PM
Jeroen Bakker (jbakker) planned changes to this revision.Dec 11 2019, 1:51 PM

Add normals to vbo

Jeroen Bakker (jbakker) updated this revision to Diff 20210.Dec 11 2019, 2:01 PM

Solved comments from code review:

  • Add the nor attribute to the VBO of the sphere. The DRW_cache_sphere_get is used for solid rendering (tracking + look dev).
Harbormaster completed remote builds in B5969: Diff 20210.Dec 11 2019, 2:01 PM
Jeroen Bakker (jbakker) added inline comments.Dec 11 2019, 2:02 PM
source/blender/draw/intern/draw_cache.c
89

remove this on it is not used anymore

Jeroen Bakker (jbakker) updated this revision to Diff 20211.Dec 11 2019, 2:03 PM

Removed unused field drw_sphere_nor from the DRWShapeCache.

Harbormaster completed remote builds in B5970: Diff 20211.Dec 11 2019, 2:03 PM
Jeroen Bakker (jbakker) edited the summary of this revision. (Show Details)Dec 11 2019, 2:04 PM
Clément Foucault (fclem) accepted this revision.Dec 12 2019, 2:33 PM
This revision is now accepted and ready to land.Dec 12 2019, 2:33 PM
Closed by commit rBb30a722f2d6f: Fix T72124: LookDev Sphere Rendering (authored by Jeroen Bakker (jbakker)). · Explain WhyDec 18 2019, 10:57 AM
This revision was automatically updated to reflect the committed changes.
Jeroen Bakker (jbakker) added a commit: rBb30a722f2d6f: Fix T72124: LookDev Sphere Rendering.

Revision Contents
Changeset List

PathSize
source/
blender/
draw/
intern/
10 lines

Diff 20376

View Options

source/blender/draw/intern/draw_cache.c

Loading...