Page MenuHome
Differential D6425

convert all gl_FragColor variables to FragColor
ClosedPublic
Actions

Authored by Jean First (robbott) on Dec 17 2019, 3:24 AM.

Details

Reviewers
Sergey Sharybin (sergey)
Jacques Lucke (JacquesLucke)
Commits
rB4fa424546438: PyDocs: GPU Module: Examples: convert all gl_FragColor variables to FragColor
Summary

if the commit D6424 is correct, maybe all gl_FragColor variables should be converted to FragColor.

Diff Detail

Repository
rB Blender
Branch
gl_fragcolor (branched from master)
Build Status
Buildable 6037
Build 6037: arc lint + arc unit

Event Timeline

Jean First (robbott) created this revision.Dec 17 2019, 3:24 AM
Harbormaster completed remote builds in B6037: Diff 20340.Dec 17 2019, 3:24 AM
Damien Picard (pioverfour) mentioned this in rBA95e98889aba9: sun_position: Fix T72495 traceback error when trying to activate.Dec 17 2019, 12:40 PM
Damien Picard (pioverfour) added reviewers: Sergey Sharybin (sergey), Jacques Lucke (JacquesLucke).Dec 17 2019, 2:10 PM
Damien Picard (pioverfour) added subscribers: Jacques Lucke (JacquesLucke), Sergey Sharybin (sergey), Damien Picard (pioverfour).

D6424 fixed an openGL bug on macos.

This diff fixes at least the Python examples, I don’t know about opensubdiv.
@Sergey Sharybin (sergey) committed the opensubdiv shader and @Jacques Lucke (JacquesLucke) the Python examples.

Sergey Sharybin (sergey) added a comment.Dec 17 2019, 3:55 PM

The documentation part seems fine.

The OpeSubdiv is not currently in use and likely have other issue. Commented on mistake in this shader anyway.

intern/opensubdiv/shader/gpu_shader_opensubdiv_fragment.glsl
68

To my knowledge input and output are reserved keywords in the language. This is a reason why input is called inpt. So here it should be outpt.

73

outpt.FragColor = diffuse;

167

Similar to above.

Jean First (robbott) updated this revision to Diff 20353.Dec 17 2019, 4:28 PM

convert all gl_FragColor variables to FragColor

Harbormaster completed remote builds in B6041: Diff 20353.Dec 17 2019, 4:28 PM
This revision was not accepted when it landed; it landed in state Needs Review.Oct 14 2020, 5:20 PM
Closed by commit rB4fa424546438: PyDocs: GPU Module: Examples: convert all gl_FragColor variables to FragColor (authored by Aaron Carlisle (Blendify)). · Explain Why
This revision was automatically updated to reflect the committed changes.
Aaron Carlisle (Blendify) added a commit: rB4fa424546438: PyDocs: GPU Module: Examples: convert all gl_FragColor variables to FragColor.

Revision Contents
Changeset List

PathSize
doc/
python_api/
examples/
3 lines
3 lines
3 lines
intern/
opensubdiv/
shader/
10 lines

Diff 20340

View Options

doc/python_api/examples/gpu.11.py

Loading...
View Options

doc/python_api/examples/gpu.3.py

Loading...
View Options

doc/python_api/examples/gpu.8.py

Loading...
View Options

intern/opensubdiv/shader/gpu_shader_opensubdiv_fragment.glsl

Loading...