Page MenuHome
Differential D6436

Workbench: Force Vertex Colors in Paint Mode
ClosedPublic
Actions

Authored by Jeroen Bakker (jbakker) on Dec 18 2019, 10:19 AM.

Details

Reviewers
Clément Foucault (fclem)
Maniphest Tasks
T69630: Vertex Paint Mode Shows Wrong Colours
Commits
rB409d3f48809c: Workbench: Force Vertex Colors in Paint Mode
Summary

Vertex colors behaved differently as the paint overlay mixed the colors
in display mode and the results was multiplied on top of the original
shading.

This patch will align the implementation to texture painting where the
colors are drawn by the workbench engine so the correct shading is
applied.

This also means that we don't show the vertex colors overlay when not
in solid mode.

Diff Detail

Repository
rB Blender

Event Timeline

Jeroen Bakker (jbakker) created this revision.Dec 18 2019, 10:19 AM
Jeroen Bakker (jbakker) updated this revision to Diff 20373.Dec 18 2019, 10:26 AM

Code style + rename struct to a smaller name. It didn't had to be that specific anyhow and smaller names will give better code formatting

Harbormaster completed remote builds in B6049: Diff 20372.Dec 18 2019, 10:30 AM
Harbormaster completed remote builds in B6050: Diff 20373.
Jeroen Bakker (jbakker) added a reviewer: Clément Foucault (fclem).Dec 18 2019, 10:36 AM
Jeroen Bakker (jbakker) added a project: GPU / Viewport.
Jeroen Bakker (jbakker) updated this revision to Diff 20374.Dec 18 2019, 10:38 AM

Missed a const

Harbormaster completed remote builds in B6051: Diff 20374.Dec 18 2019, 10:38 AM
Jeroen Bakker (jbakker) edited the summary of this revision. (Show Details)Dec 18 2019, 10:44 AM
Clément Foucault (fclem) accepted this revision.Dec 18 2019, 12:30 PM
This revision is now accepted and ready to land.Dec 18 2019, 12:30 PM
Closed by commit rB409d3f48809c: Workbench: Force Vertex Colors in Paint Mode (authored by Jeroen Bakker (jbakker)). · Explain WhyDec 18 2019, 1:31 PM
This revision was automatically updated to reflect the committed changes.
Jeroen Bakker (jbakker) added a commit: rB409d3f48809c: Workbench: Force Vertex Colors in Paint Mode.
Jose (Dogway) mentioned this in T73063: Wireframe Overlay Drawing.Jan 13 2020, 2:01 PM

Revision Contents
Changeset List

PathSize
source/
blender/
draw/
engines/
overlay/
11 lines
workbench/
57 lines
61 lines
79 lines
41 lines
makesrna/
intern/
2 lines

Diff 20381

View Options

source/blender/draw/engines/overlay/overlay_paint.c

Loading...
View Options

source/blender/draw/engines/workbench/workbench_deferred.c

Loading...
View Options

source/blender/draw/engines/workbench/workbench_forward.c

Loading...
View Options

source/blender/draw/engines/workbench/workbench_materials.c

Loading...
View Options

source/blender/draw/engines/workbench/workbench_private.h

Loading...
View Options

source/blender/makesrna/intern/rna_space.c

Loading...