Differential D6440

Fix T72236: UV Stretching Overlay
ClosedPublic
Actions

Authored by Jeroen Bakker (jbakker) on Dec 18 2019, 4:14 PM.

Tags

None

Subscribers

None

Details

Reviewers

Clément Foucault (fclem)
Germano Cavalcante (mano-wii)

Maniphest Tasks

T72236: UV Stretching Area overlay fails when object has small dimensions

Commits

rB4440739699bb: Fix T72236: UV Stretching Overlay

Summary

The ratio for area stretching was packed into an unsigned int, but could
contain negative numbers. This flipped the negative numbers to high
positive numbers and rendered the wrong color in the stretching overlay.

I can remember that with T63755: [UV] [Multi-Edit] Display>Stretch>Area doesn't work I needed to flip the sign to get the
correct result, but couldn't find out why that was needed. Now I know.

Diff Detail

Repository: rB Blender

Event Timeline

Jeroen Bakker (jbakker) created this revision.Dec 18 2019, 4:14 PM

Harbormaster completed remote builds in B6053: Diff 20384.Dec 18 2019, 4:15 PM

Jeroen Bakker (jbakker) added a reviewer: Germano Cavalcante (mano-wii).Dec 18 2019, 4:23 PM

I tested and compared with 2.79, the patch it's working fine.

This revision is now accepted and ready to land.Dec 18 2019, 5:26 PM

Clément Foucault (fclem) accepted this revision.Dec 18 2019, 6:19 PM

Closed by commit rB4440739699bb: Fix T72236: UV Stretching Overlay (authored by Jeroen Bakker (jbakker)). · Explain WhyDec 19 2019, 8:35 AM

This revision was automatically updated to reflect the committed changes.

Jeroen Bakker (jbakker) added a commit: rB4440739699bb: Fix T72236: UV Stretching Overlay.

Revision Contents
Changeset List

Path

Size

source/

blender/

draw/

intern/

draw_cache_extract_mesh.c

4 lines

gpu/

shaders/

gpu_shader_2D_edituvs_stretch_vert.glsl

2 lines

Diff 20407

source/blender/draw/intern/draw_cache_extract_mesh.c

Loading...

source/blender/gpu/shaders/gpu_shader_2D_edituvs_stretch_vert.glsl

Loading...