Details

Reviewers

Jeroen Bakker (jbakker)
William Reynish (billreynish)

Group Reviewers

User Interface

Commits

rB1c1a14dcdfff: Voxel Remesh: Edit Voxel Size operator

Summary

This operator lets the user control the voxel/detail size of the voxel remesher directly from the 3D view in a similar way the Brush radius and strength are controlled. The shorcut from sculpt mode is Shift + R (similar to Shift + F for brush strength).

It shows a grid that represents the real voxel size of the object. The grid and the text are automatically aligned to the view to avoid rendering all voxels with thousands of lines.

It also has a slow mode when pressing shift that works like the slow mode of the brush radius control.

Diff Detail

Repository

rB Blender

Branch

sculpt-voxel-size-edit (branched from master)

Build Status

Buildable 6075
Build 6075: arc lint + arc unit

Event Timeline

Pablo Dobarro (pablodp606) created this revision.Dec 18 2019, 10:53 PM

Harbormaster completed remote builds in B6068: Diff 20400.Dec 18 2019, 10:53 PM

Pablo Dobarro (pablodp606) edited the summary of this revision. (Show Details)Dec 18 2019, 10:58 PM

Pablo Dobarro (pablodp606) added a reviewer: Jeroen Bakker (jbakker).

Pablo Dobarro (pablodp606) added a project: BF Blender (2.82).

Brandon (Brandon777) awarded a token.Dec 18 2019, 11:15 PM

Maged afra (Maged_afra) awarded a token.Dec 18 2019, 11:28 PM

Julien Kaspar (JulienKaspar) added a subscriber: Julien Kaspar (JulienKaspar).Dec 18 2019, 11:31 PM

Rodger Davis (RodDavis) awarded a token.Dec 18 2019, 11:45 PM

CobraA (CobraA) awarded a token.Dec 19 2019, 12:00 AM

Zino Guerr (Zino) awarded a token.Dec 19 2019, 12:02 AM

Sam Van Hulle (sam_vh) awarded a token.Dec 19 2019, 12:08 AM

Kenn Nyström (Frozen_Death_Knight) awarded a token.Dec 19 2019, 12:13 AM

Scale the grid from the center instead of from a corner

I think it looks better this way

Harbormaster completed remote builds in B6069: Diff 20401.Dec 19 2019, 12:22 AM

This looks great! It would be good to add the units to the number as well though, it could be confusing working at different scales than this.

Rahul Chaudhary (RC12) awarded a token.Dec 19 2019, 7:32 AM

Flo Tasser (TheFlow) awarded a token.Dec 19 2019, 7:53 AM

xrg (xrg) awarded a token.Dec 19 2019, 7:56 AM

Tobias Fuchsberger (Kronk) awarded a token.Dec 19 2019, 8:33 AM

Metin Seven (MetinSeven) awarded a token.Dec 19 2019, 9:12 AM

Vertex (VertexPainter) added a subscriber: Vertex (VertexPainter).Dec 19 2019, 9:37 AM

noki paike (amonpaike) awarded a token.Dec 19 2019, 9:57 AM

Hi Pablo, thats great. As the visualization seems placed at the meshes frontfacing boundingbox side rather than the current mouse position. Is it possible that you also enable this visualization while dragging the slider in the toolsettings remesh popup at the top of the viewport? I think it's as helpful if its contolled from there.

And even if it's slightly offtopic I'd find it very useful to have it the same way for radius and strength previews placed at the boundingbox side if brush radius and strength is setup from within the toolsettings.

Debuk (Debuk) awarded a token.Dec 19 2019, 10:55 AM

Lopo Isaac (lopoIsaac) awarded a token.Dec 19 2019, 12:20 PM

Konstantina Anagnostou (Constantina32) added a subscriber: Konstantina Anagnostou (Constantina32).Dec 19 2019, 12:52 PM

Konstantina Anagnostou (Constantina32) awarded a token.Dec 19 2019, 12:58 PM

Fran Marz (franMarz) awarded a token.Dec 19 2019, 5:44 PM

Fix bug when rendering the grid

Harbormaster completed remote builds in B6075: Diff 20418.Dec 19 2019, 6:23 PM

Seb (Daxter753) added a subscriber: Seb (Daxter753).Dec 20 2019, 5:35 AM

Ismael Fabián del Toro (fukus) added a subscriber: Ismael Fabián del Toro (fukus).Dec 20 2019, 1:48 PM

On architecture side I think it is better to implement this as a gizmo as that will make it usable in other areas of blender.
I also added the UX team as reviewer to comment on the design and usability.

I also would like to mention that right now this is a workaround for an important bug in sculpt mode. When editing the voxel size directly in the mesh property Blender is constantly rebuilding the PBVH as you drag to tweak the value. That makes impossible to tweak the value in high poly meshes as the rebuild usually takes about 3 seconds. When you use this operator that does not happen.

Think this is an awesome feature - a very nice way to visualize what the operator does. I agree with Jeroen though, this should be implemented using gizmos.

@Jeroen Bakker (jbakker) @Julian Eisel (Severin) Is there any other functionality in Blender similar to this that uses gizmos to use as a reference for implementation? The most similar thing I found are the brush radius controls like WM_OT_radial_control and they are implemented the same way as this, they just let you choose a data path for the property to control (I can easily add that to this patch, but I don't think that makes much sense now).

Leonardo (tenshi7007) added a subscriber: Leonardo (tenshi7007).Jan 19 2020, 2:18 PM

Pablo Dobarro (pablodp606) mentioned this in T73448: Sculpt Mode Project TODO.Jan 28 2020, 4:34 AM

Pablo Dobarro (pablodp606) mentioned this in T63745: Sculpt, Paint, Texture Module.Feb 4 2020, 4:45 PM

Simon (Shimoon) awarded a token.Feb 17 2020, 4:18 PM

Rebase

Harbormaster completed remote builds in B6922: Diff 22333.Mar 3 2020, 4:37 PM

Way awarded a token.Mar 6 2020, 5:00 PM

I tried the operator you could improve by using a different input curve. The current one does not feel consistent.
Also I expected to have more the feeling of a scale transform operator.
Perhaps implement it as a radial and wrap around screens.
Limit when reaching small numbers. Currently the grid disappears, but the text still goes down. As this is a visual operator the grid is more important than the text.
Personally I found the text not saying anything useful. perhaps just remove it, or make it less prominent or something else.

source/blender/editors/object/object_remesh.c
234	`\|\| tot_lines_half < 2` can be removed
312	Incorrect string format ("%3.4f%%")

This revision now requires changes to proceed.Mar 10 2020, 1:05 PM

Rebase
Review Update

Harbormaster completed remote builds in B7065: Diff 22620.Mar 10 2020, 1:38 PM

@Jeroen Bakker (jbakker) One of the main advantages of this operator is its input curve compared to regular UI widget. The relation between the voxel size and the final mesh resolution is cubic, so the operator has more precise control automatically the higher the voxel size is to prevent you for jumping to a unmanageable mesh resolution when working with high poly meshes. The relation between the input and the voxel size does not feel consistent, but the relation between input and final mesh resolution is.
Also, I made the grid disappear when reaching small voxel size because and that point it adds to much noise to the widget and it does not produce any relevant visual information (it looks like a solid white plane). Most users now are used to memorized a set of voxel size values which produced a desired mesh resolution, that is why the number is there.

Connor McCampbell (realeyez) awarded a token.Mar 11 2020, 5:16 PM

Connor McCampbell (realeyez) added a subscriber: Connor McCampbell (realeyez).

Would it be an idea to fade out the grid when the number is tiny. Not rendering it may feel like a bug and users will report it.

Rebase
Fade out grid as the line number increases

Harbormaster completed remote builds in B7123: Diff 22729.Mar 12 2020, 3:04 PM

Carl Knight (knightknight) awarded a token.Mar 13 2020, 9:58 AM

Joseph Brandenburg (TheAngerSpecialist) awarded a token.Mar 14 2020, 2:20 AM

Diogo Valadares Reis dos Santos (DiogoX2) awarded a token.Mar 14 2020, 5:01 PM

When the grid is fully faded away, banding appear

It is possible to get the control in a state where it is not possible to increase the voxel size

This revision now requires changes to proceed.Mar 16 2020, 11:37 AM

Enable linear mode when pressing Ctrl, this enables jumping to any voxel size regardless of the initial value.

I don't think the banding issues are related to this patch, as it is an issue in all operators (try the knife tool and move the cursor for a while). The banding does not appear if AA is disabled.

Harbormaster completed remote builds in B7184: Diff 22851.Mar 17 2020, 1:21 AM

Leonardo (tenshi7007) removed a subscriber: Leonardo (tenshi7007).Mar 17 2020, 8:22 AM

Yes, I solved the banding issue today. So I don't have any objections so far. Finetuning can still be done in master.