Page MenuHome
Differential D6451

Fix T72546: Video Sequencer: Select grouped 'OVERLAP' operator wrong selection
ClosedPublic
Actions

Authored by Philipp Oeser (lichtwerk) on Dec 19 2019, 10:26 AM.

Details

Reviewers
Richard Antalik (ISS)
Jeroen Bakker (jbakker)
Maniphest Tasks
T72546: Video Sequencer: Select grouped 'OVERLAP' operator wrong selection
Commits
rBddddb94517bc: Fix T72546: Video Sequencer: Select grouped 'OVERLAP' operator wrong selection
Summary

False positive when a sequences end would be the same as active
sequences start.

Diff Detail

Repository
rB Blender

Event Timeline

Philipp Oeser (lichtwerk) created this revision.Dec 19 2019, 10:26 AM
Harbormaster completed remote builds in B6071: Diff 20408.Dec 19 2019, 10:26 AM
Philipp Oeser (lichtwerk) added a project: Video Sequencer.Jan 16 2020, 5:38 PM
Jeroen Bakker (jbakker) accepted this revision.Jan 20 2020, 11:46 AM
This revision is now accepted and ready to land.Jan 20 2020, 11:46 AM
Richard Antalik (ISS) accepted this revision.Jan 20 2020, 11:55 AM
Sybren A. Stüvel (sybren) added a subscriber: Sybren A. Stüvel (sybren).Jan 20 2020, 12:58 PM
Sybren A. Stüvel (sybren) added inline comments.
source/blender/editors/space_sequencer/sequencer_select.c
1295

Can we apply some of DeMorgan's laws here to clean this up?

if (seq->startdisp < actseq->enddisp && seq->enddisp > actseq->startdisp) {
Closed by commit rBddddb94517bc: Fix T72546: Video Sequencer: Select grouped 'OVERLAP' operator wrong selection (authored by Philipp Oeser (lichtwerk)). · Explain WhyJan 20 2020, 9:24 PM
This revision was automatically updated to reflect the committed changes.
Philipp Oeser (lichtwerk) added a commit: rBddddb94517bc: Fix T72546: Video Sequencer: Select grouped 'OVERLAP' operator wrong selection.

Revision Contents
Changeset List

PathSize
source/
blender/
editors/
space_sequencer/
2 lines

Diff 21014

View Options

source/blender/editors/space_sequencer/sequencer_select.c

Loading...