Differential D6476

Fix T71712: Free the dynamic mesh preview when rebuilding the PBVH
ClosedPublic
Actions

Authored by Pablo Dobarro (pablodp606) on Dec 24 2019, 12:44 AM.

Details

Reviewers

Jeroen Bakker (jbakker)

Maniphest Tasks

T71712: Blender crashes after using Voxel Remesher in sculpt mode on an object with Subdivision Surface modifier

Commits

rB22f5edcf45e8: Fix T71712: Free the dynamic mesh preview when rebuilding the PBVH

Summary

The PBVH usually is rebuild after a topology change, so it does not make
sense to keep the previous dynamic mesh preview vertex list. This may
cause a crash is the number of vertices of the new mesh (and preview) is
larger previous one. Now the list is deleted with the PBVH and a new one
will be generated using the new mesh when the cursor is updated.

Diff Detail

Repository: rB Blender

Event Timeline

Pablo Dobarro (pablodp606) created this revision.Dec 24 2019, 12:44 AM

Harbormaster completed remote builds in B6102: Diff 20474.Dec 24 2019, 12:44 AM

Pablo Dobarro (pablodp606) added a reviewer: Jeroen Bakker (jbakker).Dec 30 2019, 4:43 PM

Code was good, but better to use MEM_SAFE_FREE for these cases

source/blender/blenkernel/intern/paint.c
1026	MEM_SAFE_FREE(ss->preview_vert_index_list) ss->preview_vert_index_count = 0; Same thing can also be done for the other parts of this function. a bit shorter