Proposed fix for 70121
AbandonedPublic
Actions

Authored by Antonio Vazquez (antoniov) on Dec 24 2019, 10:47 AM.

Details

Reviewers

Clément Foucault (fclem)
Jeroen Bakker (jbakker)

Summary

Instead to render all object type for grease pencil object engine, now only this type is filtered. In theory, GP engine does not need review any other type.

@Clément Foucault (fclem) I have doubts about LIGHTS for the new refactored engine. Maybe LIGHTS must be included always.

For the rest of engines, all objects are included.

Diff Detail

Repository

rB Blender

Branch

temp-T70121 (branched from master)

Build Status

Buildable 6105
Build 6105: arc lint + arc unit

Event Timeline

Antonio Vazquez (antoniov) created this revision.Dec 24 2019, 10:47 AM

Harbormaster completed remote builds in B6104: Diff 20479.Dec 24 2019, 10:47 AM

Antonio Vazquez (antoniov) mentioned this in T70121: Segfault with Grease Pencil and camera on a path.Dec 24 2019, 10:47 AM

Antonio Vazquez (antoniov) edited the summary of this revision. (Show Details)

Antonio Vazquez (antoniov) edited the summary of this revision. (Show Details)Dec 24 2019, 10:51 AM

Antonio Vazquez (antoniov) added reviewers: Clément Foucault (fclem), Jeroen Bakker (jbakker).

Antonio Vazquez (antoniov) added a project: Grease Pencil.

Antonio Vazquez (antoniov) added a subscriber: Clément Foucault (fclem).

Inlude always LAMP types

Harbormaster completed remote builds in B6105: Diff 20480.Dec 24 2019, 10:55 AM

I am not sure if this solves the root cause, or just hides it for this specific case, but might fail for other cases.

In D6477#153029, @Jeroen Bakker (jbakker) wrote:

I am not sure if this solves the root cause, or just hides it for this specific case, but might fail for other cases.

Me neither. My only assumption is that the grease pencil engine only needs grease pencil objects and lamps.

This is not the proper fix. Assigning the task to myself.